1250: added plugin to prevent disabling default source #1410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naydav
suggested changes
Jun 22, 2018
| * @var DefaultSourceProviderInterface | ||
| */ | ||
| private $defaultSourceProvider; | ||
| /** |
| return $meta; | ||
| } | ||
|
|
||
| //$result[$defaultSourceCode]['general']['switcher_disabled'] = true; |
| * @param SourceDataProvider $subject | ||
| * @return bool | ||
| */ | ||
| private function isFormComponent(SourceDataProvider $subject): bool |
There was a problem hiding this comment.
Why do we need to incapsulate one string in the separate function?
| /** | ||
| * @return bool | ||
| */ | ||
| private function isFormComponent(): bool |
| @@ -25,4 +25,7 @@ | |||
| <argument name="sortOrder" xsi:type="number">30</argument> | |||
| </arguments> | |||
| </virtualType> | |||
| <type name="Magento\InventoryAdminUi\Ui\DataProvider\SourceDataProvider"> | |||
| <plugin name="prevent_disabling_default_source_plugin" type="Magento\InventoryAdminUi\Plugin\InventoryAdminUi\Ui\DataProvider\PreventDisablingDefaultSourcePlugin"/> | |||
naydav
suggested changes
Jun 25, 2018
| */ | ||
| declare(strict_types=1); | ||
|
|
||
| namespace Magento\InventoryAdminUi\Plugin\InventoryAdminUi\Ui\DataProvider; |
There was a problem hiding this comment.
Need to move plugin and declaration to InventoryCatalogAdminUi because
Default Source is concept of InventoryCatalog
This was referenced Jun 29, 2018
ishakhsuvarov
deleted the
MSI-1250-Prevent-Disabling-Default-Source-by-Disabling-Is-Enabled-Switcher
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added plugin for prevent disable Default Source using Switcher.
Fixed Issues (if relevant)
Manual testing scenarios
Go to:
Edit Source: Default Source
Switcher should be disabled.