Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX MSI magento-engcom/magento#70: #71

Merged
merged 1 commit into from
Sep 2, 2017
Merged

FIX MSI magento-engcom/magento#70: #71

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/code/Magento/Inventory/Indexer/IndexHandlerInterface.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ interface IndexHandlerInterface
* @param \Traversable $documents
* @return void
*/
public function saveIndex(IndexName $indexName, \Traversable $documents): void;
public function saveIndex(IndexName $indexName, \Traversable $documents);

/**
* Remove data from index
Expand All @@ -28,5 +28,5 @@ public function saveIndex(IndexName $indexName, \Traversable $documents): void;
* @param \Traversable $documents
* @return void
*/
public function deleteIndex(IndexName $indexName, \Traversable $documents): void;
public function deleteIndex(IndexName $indexName, \Traversable $documents);
}
4 changes: 2 additions & 2 deletions app/code/Magento/Inventory/Indexer/IndexStructureInterface.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,12 @@ interface IndexStructureInterface
* @param string $connectionName
* @return void
*/
public function create(IndexName $indexName, string $connectionName = ResourceConnection::DEFAULT_CONNECTION): void;
public function create(IndexName $indexName, string $connectionName = ResourceConnection::DEFAULT_CONNECTION);

/**
* @param IndexName $indexName
* @param string $connectionName
* @return void
*/
public function delete(IndexName $indexName, string $connectionName = ResourceConnection::DEFAULT_CONNECTION): void;
public function delete(IndexName $indexName, string $connectionName = ResourceConnection::DEFAULT_CONNECTION);
}
5 changes: 1 addition & 4 deletions app/code/Magento/Inventory/Indexer/IndexTableSwitcherInterface.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,5 @@ interface IndexTableSwitcherInterface
* @param string $connectionName
* @return void
*/
public function switch(
IndexName $indexName,
string $connectionName = ResourceConnection::DEFAULT_CONNECTION
): void;
public function switch(IndexName $indexName, string $connectionName = ResourceConnection::DEFAULT_CONNECTION);
}
4 changes: 2 additions & 2 deletions app/code/Magento/Inventory/Indexer/StockItem/IndexHandler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ public function __construct(
/**
* @inheritdoc
*/
public function saveIndex(IndexName $indexName, \Traversable $documents): void
public function saveIndex(IndexName $indexName, \Traversable $documents)
{
$tableName = $this->indexNameResolver->resolveName($indexName);

Expand All @@ -73,7 +73,7 @@ public function saveIndex(IndexName $indexName, \Traversable $documents): void
/**
* @inheritdoc
*/
public function deleteIndex(IndexName $indexName, \Traversable $documents): void
public function deleteIndex(IndexName $indexName, \Traversable $documents)
{
$tableName = $this->indexNameResolver->resolveName($indexName);

Expand Down
4 changes: 2 additions & 2 deletions app/code/Magento/Inventory/Indexer/StockItem/IndexStructure.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ public function __construct(
/**
* @inheritdoc
*/
public function create(IndexName $indexName, string $connectionName = ResourceConnection::DEFAULT_CONNECTION): void
public function create(IndexName $indexName, string $connectionName = ResourceConnection::DEFAULT_CONNECTION)
{
$connection = $this->resourceConnection->getConnection($connectionName);
$tableName = $this->indexNameResolver->resolveName($indexName);
Expand Down Expand Up @@ -93,7 +93,7 @@ public function create(IndexName $indexName, string $connectionName = ResourceCo
/**
* @inheritdoc
*/
public function delete(IndexName $indexName, string $connectionName = ResourceConnection::DEFAULT_CONNECTION): void
public function delete(IndexName $indexName, string $connectionName = ResourceConnection::DEFAULT_CONNECTION)
{
$connection = $this->resourceConnection->getConnection($connectionName);
$tableName = $this->indexNameResolver->resolveName($indexName);
Expand Down
6 changes: 2 additions & 4 deletions app/code/Magento/Inventory/Indexer/StockItem/IndexTableSwitcher.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,10 +49,8 @@ public function __construct(
/**
* @inheritdoc
*/
public function switch(
IndexName $indexName,
string $connectionName = ResourceConnection::DEFAULT_CONNECTION
): void {
public function switch(IndexName $indexName, string $connectionName = ResourceConnection::DEFAULT_CONNECTION)
{
$connection = $this->resourceConnection->getConnection($connectionName);
$tableName = $this->indexNameResolver->resolveName($indexName);

Expand Down