#142 : [New Rule] No imports from static tests namespaces #149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lenaorobei
requested changes
Oct 14, 2019
| @@ -0,0 +1,51 @@ | |||
| <?php | |||
There was a problem hiding this comment.
I'd like to have UseDeclarationSniff.md file that will describe the issue behind
m2-community-project
bot
added
Progress: review
and removed
Progress: changes requested
labels
|
I'm still working on group namespace changes |
ihor-sviziev
requested changes
Dec 4, 2019
m2-community-project
bot
added
Progress: changes requested
and removed
Progress: review
labels
Exclude running for tests
m2-community-project
bot
added
Progress: review
and removed
Progress: changes requested
labels
ihor-sviziev
previously approved these changes
Dec 4, 2019
|
@lenaorobei could you review this PR? Approved from my side |
|
Changes look good to me. I'll run against Magento code to see if there is no issues and will merge it. |
lenaorobei
approved these changes
Dec 11, 2019
magento-devops-reposync-svc
pushed a commit
that referenced
this pull request
Jan 26, 2022
…ff-to-check-closing-tags [Pyrrans] AC-1999: Static test to check void closing tags
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New ruleset added which will prevent importing static test namespaces
Fixed issue : #142