Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pangolins Sprint 11 #7

Merged
merged 34 commits into from
Oct 24, 2017
Merged

Pangolins Sprint 11 #7

merged 34 commits into from
Oct 24, 2017

Conversation

tomreece
Copy link
Contributor

@tomreece tomreece commented Oct 20, 2017

Scope

Stories

  • MQE-391 Variable is not correctly resolved when array symbol ([ or ]) is inside $$ signs
  • MQE-377 [Data Input] Data Persistence through Frontend http request and Create API metadata for Wishlist
  • MQE-431 Automatically check for copyright at the top of every framework file
  • MQE-345 [DevOps] [Customizability] Create suite schema declaration and supporting interpretation
  • MQE-418 [Generator] Quote issue in generator for parameterArray
  • MQE-409 [Data Input] Action Groups need to extend persisted data as args
  • MQE-453 [DevOps] Add optional arg for consolidated test run
  • MQE-391 Variable is not correctly resolved when array symbol ([ or ]) is inside $$ signs
  • MQE-460 OperationDataArrayResolver does not correctly resolve meta data object type's key attribute.
  • MQE-425 Create test to validate changes between commits with php unit
  • MQE-460 OperationDataArrayResolver does not correctly resolve meta data object type's key attribute.
  • MQE-446 Unable to pass ActionGroup argument into parameterized selector
  • MQE-457 Error when using literal param with space in elements
  • MQE-429 API - Implement PUT requests
  • MQE-237 [Generator] Add before and after logic to suites
  • MQE-426 License File and Copyright
  • MQE-440 [Metadata] Create API metadata for configurable product

Related Pull Requests

https://github.com/magento/magento2ce/pull/1615
https://github.com/magento/magento2ee/pull/760

KevinBKozan and others added 30 commits October 2, 2017 10:06
…) is inside $$ signs

- Added check for syntax of $data.key[index]$, if so generates line like "$data.getCreatedData('key')['index']
…) is inside $$ signs

- Reverted most changes and just kept regex change to accomodate [].
…ork file

- Add copyright-check, a bash script to check for the Magento copyright in all tracked files
- Fix various missing or incorrect copyrights
…ork file

- Add composer-git-hooks dependency
…d supporting interpretation

    - add new suite objects, handler, parser classes
    - alter di.xml file to include new suite parsing
    - add new resolver for root level dir
    - change cest objects and test generators to fit with suite design
…d supporting interpretation

- fix for codesniff tests
* MQE-418: [Generator] Quote issue in generator for parameterArray

- Removed all processing of parameterArray, as current implementation was causing the errors.
- Simple setting fixes all known usecases for the parameterArray attribute.
- Merged and Reverted erroneous merge.
…args

- ActionGroupObject now correctly handles $datakey$ references.
- Fixed in-line doc to match structure.
- Code Review changes for comments.
    - add param for config flag and env to TestManifest Constructor
    - change generate tests signature for new flags
…ta object type's key attribute.

- fixed array reference to key instead of type when building request data
…ork file

- Add copyright to more files that were recently added
…ork file

- Refactor, rename, add comment to blacklist file
    - add verification and unit test structure
    - add verification and unit tests
    - add test utils
    - add bootstrap setup file and phpunit.xml configuration
    - change object handler classes to trigger notices for missing xml
…ta object type's key attribute.

    - fixed array reference to key instead of type when building request data
…ork file

- Adding copyright to a file which made it to sprint-develop before this task.
- ActionGroupObject now correctly handles $datakey$ references.
- Refactoring of existing methods, creation of new methods to consolidate code.
- changed regex to accept all characters, not inside $data.ref$ and 'string literal` parameters.
- add new before/after tags
- add new Group generator class
- add verification test for new suite logic
- update existing suite sample file
- add Group object dir to .gitignore
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants