MAGETWO-70883: Prevent change log entry when nothing has changed #4893

- Coding Style fixes
magento · Jul 21, 2017 · 5b9888b · 5b9888b
1 parent e21bd31
commit 5b9888b
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 3 deletions.
diff --git a/app/etc/di.xml b/app/etc/di.xml
@@ -1330,4 +1330,11 @@
             <argument name="configSource" xsi:type="object">Magento\Config\App\Config\Source\EnvironmentConfigSource</argument>
         </arguments>
     </type>
+    <type name="Magento\Framework\Mview\View\Subscription">
+        <arguments>
+            <argument name="ignoredUpdateColumns" xsi:type="array">
+                <item name="updated_at" xsi:type="string">updated_at</item>
+            </argument>
+        </arguments>
+    </type>
 </config>
diff --git a/lib/internal/Magento/Framework/Mview/View/Subscription.php b/lib/internal/Magento/Framework/Mview/View/Subscription.php
@@ -10,6 +10,7 @@
 
 use Magento\Framework\App\ResourceConnection;
 use Magento\Framework\DB\Ddl\Trigger;
+use Magento\Framework\Mview\View\StateInterface;
 
 class Subscription implements SubscriptionInterface
 {
@@ -58,7 +59,7 @@ class Subscription implements SubscriptionInterface
      *
      * @var array
      */
-    protected $ignoredUpdateColumns = ['updated_at'];
+    private $ignoredUpdateColumns = [];
 
     /**
      * @var Resource
@@ -72,14 +73,16 @@ class Subscription implements SubscriptionInterface
      * @param \Magento\Framework\Mview\ViewInterface $view
      * @param string $tableName
      * @param string $columnName
+     * @param array $ignoredUpdateColumns
      */
     public function __construct(
         ResourceConnection $resource,
         \Magento\Framework\DB\Ddl\TriggerFactory $triggerFactory,
         \Magento\Framework\Mview\View\CollectionInterface $viewCollection,
         \Magento\Framework\Mview\ViewInterface $view,
         $tableName,
-        $columnName
+        $columnName,
+        $ignoredUpdateColumns = []
     ) {
         $this->connection = $resource->getConnection();
         $this->triggerFactory = $triggerFactory;
@@ -88,6 +91,7 @@ public function __construct(
         $this->tableName = $tableName;
         $this->columnName = $columnName;
         $this->resource = $resource;
+        $this->ignoredUpdateColumns = $ignoredUpdateColumns;
     }
 
     /**
@@ -162,7 +166,7 @@ public function remove()
     protected function getLinkedViews()
     {
         if (!$this->linkedViews) {
-            $viewList = $this->viewCollection->getViewsByStateMode(\Magento\Framework\Mview\View\StateInterface::MODE_ENABLED);
+            $viewList = $this->viewCollection->getViewsByStateMode(StateInterface::MODE_ENABLED);
 
             foreach ($viewList as $view) {
                 /** @var \Magento\Framework\Mview\ViewInterface $view */