Prevent change log entry when nothing has changed #4893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkorotun
added
Application Framework
improvement
Issue: Ready for Work
|
We are running stable with this change for 1 month now. |
|
Any updates on this ticket? |
|
Hi @ajpevers |
|
Updated with |
|
I think that I might have time this week to look into the checks, bear with me |
Fixes magento#2987 If an entry has no changes but did get a MySQL UPDATE the trigger will not fire. This prevents entities from being reindexed when they haven't changed. This way the refresh index cron job finishes faster without any loss of functionality. This updated_at column is ignored because this is the only column that will always change, even if no attribute has been edited.
|
@ishakhsuvarov I've fixed errors that came up in the unit tests |
|
@ishakhsuvarov Done |
magento-team
pushed a commit
that referenced
this pull request
Jul 24, 2017
magento-team
pushed a commit
that referenced
this pull request
Nov 10, 2017
magento-team
pushed a commit
that referenced
this pull request
Nov 10, 2017
magento-team
pushed a commit
that referenced
this pull request
Nov 10, 2017
magento-engcom-team
pushed a commit
that referenced
this pull request
Oct 15, 2019
[Magento Community Engineering] Community Contributions - 2.3-develop latest changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2987
If an entry has no changes but did get a MySQL UPDATE the trigger will not fire.
This prevents entities from being reindexed when they haven't changed.
This way the refresh index cron job finishes faster without any loss of functionality.
This updated_at column is ignored because this is the only column that will always change, even if no attribute has been edited.