🔃 [EngCom] Public Pull Requests - 2.3-develop

Accepted Public Pull Requests:
 - #14576: Improve code structure in relation to else / if statements. (by @nuzil)
 - #14482: Fix aggregations use statements and return values (by @simpleadm)

app/code/Magento/AdminNotification/Block/System/Messages/UnreadMessagePopup.php

@@ -77,9 +77,8 @@ public function getPopupTitle()
         $messageCount = count($this->_messages->getUnread());
         if ($messageCount > 1) {
             return __('You have %1 new system messages', $messageCount);
-        } else {
-            return __('You have %1 new system message', $messageCount);
         }
+        return __('You have %1 new system message', $messageCount);
     }
 
     /**

app/code/Magento/AdminNotification/Block/Window.php

@@ -98,10 +98,9 @@ protected function _getLatestItem()
     {
         if ($this->_latestItem == null) {
             $items = array_values($this->_criticalCollection->getItems());
+            $this->_latestItem = false;
             if (count($items)) {
                 $this->_latestItem = $items[0];
-            } else {
-                $this->_latestItem = false;
             }
         }
         return $this->_latestItem;

app/code/Magento/AdvancedPricingImportExport/Model/Export/AdvancedPricing.php

@@ -626,9 +626,8 @@ protected function _getCustomerGroupById(
     ): string {
         if ($allGroups !== 0) {
             return ImportAdvancedPricing::VALUE_ALL_GROUPS;
-        } else {
-            return $this->_groupRepository->getById($groupId)->getCode();
         }
+        return $this->_groupRepository->getById($groupId)->getCode();
     }
 
     /**

app/code/Magento/AdvancedPricingImportExport/Model/Import/AdvancedPricing.php

@@ -482,9 +482,8 @@ protected function deleteProductTierPrices(array $listSku, $table)
                 $this->addRowError(ValidatorInterface::ERROR_SKU_IS_EMPTY, 0);
                 return false;
             }
-        } else {
-            return false;
         }
+        return false;
     }
 
     /**

app/code/Magento/Analytics/Model/Config/Backend/Enabled.php

@@ -67,12 +67,7 @@ public function afterSave()
         try {
             if ($this->isValueChanged()) {
                 $enabled = $this->getData('value');
-
-                if ($enabled) {
-                    $this->subscriptionHandler->processEnabled();
-                } else {
-                    $this->subscriptionHandler->processDisabled();
-                }
+                $enabled ? $this->subscriptionHandler->processEnabled() : $this->subscriptionHandler->processDisabled();
             }
         } catch (\Exception $e) {
             $this->_logger->error($e->getMessage());

app/code/Magento/Authorization/Model/ResourceModel/Role.php

@@ -68,6 +68,7 @@ protected function _beforeSave(\Magento\Framework\Model\AbstractModel $role)
         }
 
         if (!$role->getTreeLevel()) {
+            $treeLevel = 0;
             if ($role->getPid() > 0) {
                 $select = $this->getConnection()->select()->from(
                     $this->getMainTable(),
@@ -79,8 +80,6 @@ protected function _beforeSave(\Magento\Framework\Model\AbstractModel $role)
                 $binds = ['pid' => (int)$role->getPid()];
 
                 $treeLevel = $this->getConnection()->fetchOne($select, $binds);
-            } else {
-                $treeLevel = 0;
             }
 
             $role->setTreeLevel($treeLevel + 1);

app/code/Magento/Cms/Model/ResourceModel/Block/Grid/Collection.php

@@ -6,7 +6,7 @@
 namespace Magento\Cms\Model\ResourceModel\Block\Grid;
 
 use Magento\Framework\Api\Search\SearchResultInterface;
-use Magento\Framework\Search\AggregationInterface;
+use Magento\Framework\Api\Search\AggregationInterface;
 use Magento\Cms\Model\ResourceModel\Block\Collection as BlockCollection;
 
 /**
@@ -82,6 +82,7 @@ public function getAggregations()
     public function setAggregations($aggregations)
     {
         $this->aggregations = $aggregations;
+        return $this;
     }
 
     /**

app/code/Magento/Cms/Model/ResourceModel/Page/Grid/Collection.php

@@ -83,6 +83,7 @@ public function getAggregations()
     public function setAggregations($aggregations)
     {
         $this->aggregations = $aggregations;
+        return $this;
     }
 
     /**

app/code/Magento/Sales/Model/ResourceModel/Grid/Collection.php

@@ -6,7 +6,7 @@
 namespace Magento\Sales\Model\ResourceModel\Grid;
 
 use Magento\Framework\Api\Search\SearchResultInterface;
-use Magento\Framework\Search\AggregationInterface;
+use Magento\Framework\Api\Search\AggregationInterface;
 use Magento\Framework\Model\ResourceModel\Db\Collection\AbstractCollection;
 
 /**
@@ -78,6 +78,7 @@ public function getAggregations()
     public function setAggregations($aggregations)
     {
         $this->aggregations = $aggregations;
+        return $this;
     }
 
     /**