Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't close mobile search bar once typed #11231

Closed
BenSpace48 opened this issue Oct 4, 2017 · 4 comments
Closed

Can't close mobile search bar once typed #11231

BenSpace48 opened this issue Oct 4, 2017 · 4 comments
Assignees
@crissanclick
Labels
Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@BenSpace48
Copy link
Contributor

BenSpace48 commented Oct 4, 2017 •
edited
Loading

Preconditions

  1. Magento 2.1.9 using the Luma theme (no customisations)

Steps to reproduce

  1. Load the homepage on a mobile device
  2. Tap on the search icon to access the search input
  3. Start typing (but do not submit)
  4. Now tap on the search icon again to close the search bar

Sometimes it will close, but if you open it again it will not close.

Expected result

  1. Search bar closes

Actual result

  1. Nothing, search bar stays open

Happens on iOS and Android devices using different browsers, it's because the active class is not removed.

I suspect this issue was introduced as a fix for #4282

GIF

Recorded on an iPhone 5s emulator running iOS 10.3 but can replicate it on real iPhone 7 running iOS 11 to (amongst other devices including Android).

search
@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Oct 4, 2017
@okorshenko okorshenko added the Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed label Oct 4, 2017
This was referenced Oct 5, 2017
Closed
Closed
Closed
Merged
@okorshenko okorshenko added Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed and removed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Oct 5, 2017
@magento-engcom-team
Copy link
Contributor

@BenSpace48, thank you for your report.
We've created internal ticket(s) MAGETWO-81048 to track progress on the issue.

@magento-engcom-team magento-engcom-team added 2.1.x Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Oct 6, 2017
@magento-engcom-team
Copy link
Contributor

Hi @BenSpace48
the issue has been fixed in 2.2.1 and will be available soon
#11246

@magento-engcom-team magento-engcom-team added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Oct 6, 2017
@magento-team
Copy link
Contributor

Internal ticket to track issue progress: MAGETWO-81020

@magento-team
Copy link
Contributor

Hi @BenSpace48. Thank you for your report.
The issue has been fixed in magento-engcom/magento2ce#1282 by @magento-engcom-team in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming patch release.

@magento-team magento-team added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Jan 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@crissanclick crissanclick

Labels
Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@magento-team @okorshenko @BenSpace48 @crissanclick @magento-engcom-team