Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't close mobile search bar #11245

Closed

Conversation

crissanclick
Copy link
Contributor

Description

Can't close mobile search bar when using Luma Theme

Fixed Issues (if relevant)

  1. Can't close mobile search bar once typed #11231: Can't close mobile search bar once typed

Steps to reproduce

  1. Load the homepage on a mobile device
  2. Tap on the search icon to access the search input
  3. Start typing (but do not submit)
  4. Now tap on the search icon again to close the search bar

Manual testing scenarios

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Contributor

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ crissanclick
❌ Cristian Sanclemente


Cristian Sanclemente seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants