-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue with blank theme search input #4282
Comments
I can also replicate in the Luma theme (using a mobile). |
As a quick workaround without editing core files I used this jQuery (with require.js), this stops the previous toggle from firing then we toggle the active class. require(['jquery'], function($) {
var searchLabel = $('#search_mini_form .label');
searchLabel.on('click', function(event) {
event.preventDefault();
searchLabel.toggleClass('active');
});
}); |
Thank you Ben, I thought I was being a bit lame reporting such a small issue... but it really counts - especially on a serious release. |
Here a small video to see the error https://drive.google.com/file/d/0B3kBFTm6f_Kab09EemZRZmg1X0U/view?usp=sharing |
@daim2k5 That seems a bit different to the issue I'm having, here is a gif of the problem on Luma mobile. When I click on the search icon the search bar opens then immediately closes, this is on a demo store using the Luma theme (no customisations). I can also replicate on a local environment which uses a custom theme and Luma as a parent. @xAvarice Which is the issue you're having? If mine is different I will create a new ticket for it. |
@BenSpace48 I'm having that exact same issue as you. Thank you for the gif. I don't see any problem at all with Daim's video - I figure compared to this issue I don't have to look closely to compare. |
Internal issue MAGETWO-53263 |
@BenSpace48 @xAvarice looks like i had a different bug, thanks for the gif |
Closing the issue, fix has been delivered to develop branch. |
- Prevent default label click behavior when search field is active
[TSG] Fixes for 2.2 (pr100) (2.2.10-develop)
Steps to reproduce
Using Blank Theme.
Expected result
Actual result
The text was updated successfully, but these errors were encountered: