Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with blank theme search input #4282

Closed
ghost opened this issue Apr 23, 2016 · 9 comments
Closed

Issue with blank theme search input #4282

ghost opened this issue Apr 23, 2016 · 9 comments
Labels
bug report Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development

Comments

@ghost
Copy link

ghost commented Apr 23, 2016

Steps to reproduce

Using Blank Theme.

  1. Click inside search.
  2. Click to hide search.
  3. Click to show search.

Expected result

  1. Search input displays and stays on the screen.

Actual result

  1. Search input disappears due to input already being active.
@BenSpace48
Copy link
Contributor

BenSpace48 commented Apr 25, 2016

I can also replicate in the Luma theme (using a mobile).

@BenSpace48
Copy link
Contributor

As a quick workaround without editing core files I used this jQuery (with require.js), this stops the previous toggle from firing then we toggle the active class.

require(['jquery'], function($) {
    var searchLabel = $('#search_mini_form .label');

    searchLabel.on('click', function(event) {
        event.preventDefault();
        searchLabel.toggleClass('active');
    });
});

@ghost
Copy link
Author

ghost commented Apr 25, 2016

Thank you Ben, I thought I was being a bit lame reporting such a small issue... but it really counts - especially on a serious release.

@daim2k5 daim2k5 added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Apr 25, 2016
@daim2k5
Copy link
Contributor

daim2k5 commented Apr 25, 2016

Here a small video to see the error https://drive.google.com/file/d/0B3kBFTm6f_Kab09EemZRZmg1X0U/view?usp=sharing

@daim2k5 daim2k5 added the CS label Apr 25, 2016
@BenSpace48
Copy link
Contributor

BenSpace48 commented Apr 25, 2016

@daim2k5 That seems a bit different to the issue I'm having, here is a gif of the problem on Luma mobile. When I click on the search icon the search bar opens then immediately closes, this is on a demo store using the Luma theme (no customisations). I can also replicate on a local environment which uses a custom theme and Luma as a parent.

luma

@xAvarice Which is the issue you're having? If mine is different I will create a new ticket for it.

@ghost
Copy link
Author

ghost commented Apr 25, 2016

@BenSpace48 I'm having that exact same issue as you. Thank you for the gif. I don't see any problem at all with Daim's video - I figure compared to this issue I don't have to look closely to compare.

@piotrekkaminski
Copy link
Contributor

Internal issue MAGETWO-53263

@daim2k5
Copy link
Contributor

daim2k5 commented May 23, 2016

@BenSpace48 @xAvarice looks like i had a different bug, thanks for the gif

@alena-marchenko
Copy link

Closing the issue, fix has been delivered to develop branch.

okorshenko pushed a commit that referenced this issue Jun 7, 2016
- Prevent default label click behavior when search field is active
@tkacheva tkacheva removed their assignment Jun 8, 2016
ankurvr pushed a commit to ankurvr/magento2 that referenced this issue Apr 24, 2020
[TSG] Fixes for 2.2 (pr100) (2.2.10-develop)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug report Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development
Projects
None yet
Development

No branches or pull requests

6 participants