Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stock inventory reindex bug #12205

Closed
Nix-id opened this issue Nov 13, 2017 · 10 comments
Closed

Stock inventory reindex bug #12205

Nix-id opened this issue Nov 13, 2017 · 10 comments
Assignees
@p-bystritsky
Labels
Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@Nix-id
Copy link

Nix-id commented Nov 13, 2017 •
edited by magento-engcom-team
Loading

Incorrect cleaning previous index's

Preconditions

Magento 2.2.0

Steps to reproduce

in Magento\CatalogInventory\Model\ResourceModel\Indexer\Stock\DefaultStock

magento2/app/code/Magento/CatalogInventory/Model/ResourceModel/Indexer/Stock/DefaultStock.php

Line 289 in 44d2562

protected function _updateIndex($entityIds)

Expected result

Method deleteOldRecords should be called before all _updateIndexTable calls.

Actual result

Method deleteOldRecords is called after one of _updateIndexTable calls.

also can you change 'private' method and vars in this class to 'protected'? for redeclare thiss class as 'extended' for use with 'di.xml'
@magento-engcom-team magento-engcom-team added the Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed label Nov 13, 2017
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Nov 22, 2017 •
edited by daniloargentiero
Loading

@Nix-id, thank you for your report.
Please use the issue reporting guidelines to report an issue. Please, edit issue description and include the preconditions, the steps required to reproduce, the actual result, and the expected result.
Please, add the following information:

  • Preconditions: Magento version
  • Steps to reproduce
  • Expected result
  • Actual result

@magento-engcom-team magento-engcom-team added Progress: needs update Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed and removed Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Progress: needs update Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed labels Nov 22, 2017
@magento-engcom-team
Copy link
Contributor

@Nix-id, thank you for your report.
We've created internal ticket(s) MAGETWO-84414 to track progress on the issue.

@magento-engcom-team magento-engcom-team added 2.2.x Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Nov 23, 2017
@Nix-id
Copy link
Author

Nix-id commented Dec 13, 2017

Sorry for incorrect format.
but thanks for you work.

@p-bystritsky p-bystritsky self-assigned this Dec 19, 2017
@p-bystritsky
Copy link
Contributor

also can you change 'private' method and vars in this class to 'protected'? for redeclare thiss class as 'extended' for use with 'di.xml'

@Nix-id, please create new ticket for this feature request.

@magento-engcom-team magento-engcom-team added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Mar 23, 2018
@magento-engcom-team
Copy link
Contributor

Hi @Nix-id. Thank you for your report.
The issue has been fixed in magento-engcom/magento2ce#1134 by @p-bystritsky in 2.2-develop branch
Related commit(s):

The fix will be available with the upcoming 2.2.5 release.

@rogyar rogyar mentioned this issue May 2, 2018
Closed
This was referenced Sep 6, 2018
Closed
Closed
unicoder88 added a commit to ConvertGroupsAS/magento2-patches that referenced this issue Dec 7, 2018
@unicoder88
[NORLI-483] Catalog inventory reindexing by schedule > 1000 IDs
9894822 
magento/magento2#12205
@avstudnitz
Copy link
Contributor

This bug has cost us a lot of time and money after upgrading from 2.2.8 to 2.3.2.
@magento-engcom-team This fix is not included in Magento 2.3.x. Could you migrate it and make sure it will be in 2.3.3?

hostep pushed a commit to hostep/magento2 that referenced this issue Oct 27, 2019
@p-bystritsky @hostep
magento#12205: Stock inventory reindex bug.
c6d166b 
(cherry picked from commit 20d7afb)
@hostep hostep mentioned this issue Oct 27, 2019
Merged
4 tasks
@hostep
Copy link
Contributor

hostep commented Oct 27, 2019

@avstudnitz: thanks for your comment! I created a new PR to get this change included in 2.3-develop: #25306, let's hope it makes it in 2.3.4 now ...

@VladimirZaets
Copy link
Contributor

Hi @Nix-id. Thank you for your report.
The issue has been fixed in #25306 by @hostep in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.5 release.

@VladimirZaets VladimirZaets added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Nov 14, 2019
@wigman
Copy link
Contributor

wigman commented May 7, 2020

Awesome that this patch was removed in 2.3.4 again 👍

9c4c3a0#diff-9cf0a1093ac8c2558ce19f00934420d6L287

Hat tip to @SeruyV. You've costed a lot of people a lot of money.

so:

  • added in 2.2.8
  • removed in 2.3.2
  • added in 2.3.3
  • removed in 2.3.4
  • added in 2.3.5

Let's hope this is the end of the journey, yes?

@kingletas
Copy link

@wigman Yes please. I don't think this bug needs any extra stamps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@p-bystritsky p-bystritsky

Labels
Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
9 participants
@hostep @avstudnitz @kingletas @wigman @Nix-id @okorshenko @VladimirZaets @p-bystritsky @magento-engcom-team