Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAGETWO-84414 indexer DefaultStock #14139

Closed
wants to merge 3 commits into from
Closed

MAGETWO-84414 indexer DefaultStock #14139

wants to merge 3 commits into from

Conversation

m-milewski
Copy link

@m-milewski m-milewski commented Mar 16, 2018 •
edited by slavvka
Loading

Description

Deleting old records before each update index table.

Fixed Issues (if relevant)

  1. #84414: Stock inventory reindex bug

Manual testing scenarios

  1. Mass update over 1000 products.

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Mar 16, 2018 •
edited
Loading

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

@rogyar rogyar self-assigned this Mar 16, 2018
@rogyar
Copy link
Contributor

rogyar commented Apr 2, 2018

Hello @m-milewski. Please, consider fixing the failing integration tests. Thank you

@m-milewski
Copy link
Author

@rogyar I fixed fails in integration tests

rogyar
rogyar requested changes May 2, 2018
View reviewed changes
app/code/Magento/CatalogInventory/Model/ResourceModel/Indexer/Stock/DefaultStock.php
$this->deleteOldRecords($entityIds);
$this->_updateIndexTable($data);

if (is_array($data) && !empty($data)) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we are considering fix for the following issue #12205, it's already fixed withing a scope of 2.2-develop. It should be enough to remove all records at the very beginning of the index update operation without performing a separate delete in a loop.

Please, check the latest commit here https://github.com/magento/magento2/blob/2.2-develop/app/code/Magento/CatalogInventory/Model/ResourceModel/Indexer/Stock/DefaultStock.php for the clarification.

Thank you

@sidolov
Copy link
Contributor

sidolov commented Jun 18, 2018

@m-milewski , I am closing this PR now due to inactivity.
Please reopen and update if you wish to continue.
Thank you for collaboration!

@sidolov sidolov closed this Jun 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rogyar rogyar rogyar requested changes

Assignees

@rogyar rogyar

Labels
bugfix Progress: needs update Release Line: 2.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@m-milewski @magento-cicd2 @rogyar @sidolov