Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Menu ui-state-active not removed from previous opened menu item #13327

Closed
arnoudhgz opened this issue Jan 23, 2018 · 3 comments
Closed

Menu ui-state-active not removed from previous opened menu item #13327

arnoudhgz opened this issue Jan 23, 2018 · 3 comments
Assignees
@arnoudhgz
Labels
Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@arnoudhgz
Copy link
Contributor

The ui-state-active clas is not removed from the previous opened main menu item when you open a new main menu item.

Preconditions

  1. Clean Magento 2.2 installation with sample data
  2. You are in mobile view

Steps to reproduce

  1. In your browser switch to mobile view so you have the mobile menu
  2. Open the menu
  3. Expand the menu item Women
  4. Now expand the menu item Men
  5. You will see that the ui-state-active class is still also on Women

Expected result

  1. The previous opened main menu item should not have the class ui-state-active

Actual result

  1. The previous opened main menu item has the class ui-state-active (see screenshot)

image
@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Jan 23, 2018
@arnoudhgz arnoudhgz mentioned this issue Jan 23, 2018
Merged
4 tasks
@magento-engcom-team
Copy link
Contributor

@arnoudhgz, thank you for your report.
We've acknowledged the issue and added to our backlog.

@magento-engcom-team magento-engcom-team added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed and removed Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release labels Jan 23, 2018
@arnoudhgz arnoudhgz self-assigned this Jan 23, 2018
@arnoudhgz arnoudhgz mentioned this issue Jan 24, 2018
Merged
4 tasks
@magento-engcom-team
Copy link
Contributor

Hi @arnoudhgz. Thank you for your report.
The issue has been fixed in #13341 by @arnoudhgz in 2.2-develop branch
Related commit(s):

The fix will be available with the upcoming patch release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Jan 31, 2018
@okorshenko
Copy link
Contributor

Hi @arnoudhgz. Thank you for your report.
The issue has been fixed in magento-engcom/magento2ce#1380 by @magento-engcom-team in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.0 release.

@okorshenko okorshenko added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Mar 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arnoudhgz arnoudhgz

Labels
Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@okorshenko @arnoudhgz @magento-engcom-team