Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/13327 ui active state not removed from previous menu item #13341

Conversation

arnoudhgz
Copy link
Contributor

@arnoudhgz arnoudhgz commented Jan 24, 2018

Description

Previously when a menu item was expanded the class ui-state-active was
not removed from the previous expanded menu item. This resulted in two
(or more if you expanded more) menu items with this class.

Fixed Issues (if relevant)

  1. Menu ui-state-active not removed from previous opened menu item #13327 Menu ui-state-active not removed from previous opened menu item

Manual testing scenarios

  1. Get a clean install with sampledata
  2. In your browser switch to mobile view so you have the mobile menu
  3. Open the menu
  4. Expand the menu item Women
  5. Now expand the menu item Men
  6. See that the ui-state-active class is removed from Women

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

arnoudhgz and others added 2 commits January 23, 2018 13:32
Previously when a menu item was expanded the class `ui-state-active` was
not removed from the previous expanded menu item. This resulted in two
(or more if you expanded more) menu items with this class.
…-removed-from-previous-menu-item

Remove ui-state-active from siblings of the expanded menu item
@arnoudhgz
Copy link
Contributor Author

@okorshenko Now created the PR on the magento/magento2 repository. We normally do an internal check at @mediact first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants