Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/13327 ui active state not removed from previous menu item #13341

Merged
merged 2 commits into from
Jan 31, 2018
Merged

Bugfix/13327 ui active state not removed from previous menu item #13341

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5714ffd
Remove ui-state-active from siblings of the expanded menu item
arnoudhgz Jan 23, 2018
5773225
Merge pull request #8 from arnoudhgz/bugfix/13327-ui-active-state-not…
arnoudhgz Jan 24, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions lib/web/mage/menu.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -626,6 +626,9 @@ define([
return;
}

// remove the active state class from the siblings
this.active.siblings().children('.ui-state-active').removeClass('ui-state-active');

this._open(newItem.parent());

// Delay so Firefox will not hide activedescendant change in expanding submenu from AT
Expand Down