Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

product_types.xml doesn't allow numbers in modelInstance #14882

Closed
domeglic opened this issue Apr 27, 2018 · 4 comments
Closed

product_types.xml doesn't allow numbers in modelInstance #14882

domeglic opened this issue Apr 27, 2018 · 4 comments
Assignees
@lisovyievhenii
Labels
Component: Catalog Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@domeglic
Copy link

Preconditions

  1. Magento v2.2.2

Steps to reproduce

  1. Have a module with numbers in vendor name
  2. Create product_types.xml and define a new type

Expected result

  1. No XSD validation errors

Actual result

  1. XSD validation error that modelName does not validate.

product_types_base.xsd does not allow numbers in the modelName type.
Furthermore, searching for the pattern [a-zA-Z_\\] finds more files where this might be a problem.

Similar to #4470.
@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Apr 27, 2018
@ghost ghost self-assigned this Jul 12, 2018
@ghost ghost added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Component: Catalog Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Jul 13, 2018
@ghost
Copy link

ghost commented Jul 13, 2018

@domeglic, thank you for your report.
We've acknowledged the issue and added to our backlog.

@ghost ghost removed their assignment Jul 13, 2018
@lisovyievhenii lisovyievhenii self-assigned this Jan 25, 2019
@magento-engcom-team
Copy link
Contributor

Hi @lisovyievhenii. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if your want to validate it one more time, please, go though the following instruction:

  • 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 2. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 3. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 4. If the issue is not relevant or is not reproducible any more, feel free to close it.

lisovyievhenii added a commit to lisovyievhenii/magento2 that referenced this issue Jan 25, 2019
@lisovyievhenii
magento#14882: product_types.xml doesn't allow numbers in modelInstance.
9948dfe 
Fix module and models name pattern for product_types_base.xsd, product_options.xsd, import.xsd, export.xsd. Adjust unit tests, related to these files
@lisovyievhenii lisovyievhenii mentioned this issue Jan 25, 2019
Merged
4 tasks
lisovyievhenii added a commit to lisovyievhenii/magento2 that referenced this issue Jan 29, 2019
@lisovyievhenii
magento#14882: improve regular expression
3746524
@magento-engcom-team
Copy link
Contributor

Hi @domeglic. Thank you for your report.
The issue has been fixed in #20617 by @lisovyievhenii in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.2 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Feb 20, 2019
lisovyievhenii added a commit to lisovyievhenii/magento2 that referenced this issue Mar 6, 2019
@lisovyievhenii
magento#14882: product_types.xml doesn't allow numbers in modelInstan…
1c45357 
…ce. Fix module and models name pattern for product_types_base.xsd, product_options.xsd, import.xsd, export.xsd. Adjust unit tests, related to these files
lisovyievhenii added a commit to lisovyievhenii/magento2 that referenced this issue Mar 6, 2019
@lisovyievhenii
magento#14882: improve regular expression
ab8d312
@lisovyievhenii lisovyievhenii mentioned this issue Mar 6, 2019
Merged
@magento-engcom-team magento-engcom-team added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Mar 11, 2019
@magento-engcom-team
Copy link
Contributor

Hi @domeglic. Thank you for your report.
The issue has been fixed in #21598 by @lisovyievhenii in 2.2-develop branch
Related commit(s):

The fix will be available with the upcoming 2.2.9 release.

@domeglic domeglic mentioned this issue Nov 25, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lisovyievhenii lisovyievhenii

Labels
Component: Catalog Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@domeglic @lisovyievhenii @magento-engcom-team