-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
14882 product types xml doesn t allow numbers in model instance #20617
14882 product types xml doesn t allow numbers in model instance #20617
Conversation
Fetch M2 last changes
Fix module and models name pattern for product_types_base.xsd, product_options.xsd, import.xsd, export.xsd. Adjust unit tests, related to these files
Hi @lisovyievhenii. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job
Hi @swnsma, thank you for the review. |
Hi @lisovyievhenii, thank you for your contribution! |
Description
The files
product_types_base.xsd
,product_options.xsd
,import.xsd
,export.xsd
doesn't allow modules with the numbers in the name.Fixed Issues
Manual testing scenarios (*)
product_types.xml
or any other file, mentioned above.AR: XSD validation error that modelName is invalid.
Contribution checklist (*)