Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Function is unnecessarily called multiple time #15355

Closed
saurabh-parekh opened this issue May 19, 2018 · 3 comments
Closed

Function is unnecessarily called multiple time #15355

saurabh-parekh opened this issue May 19, 2018 · 3 comments
Labels
Event: dmcdindia Fixed in 2.1.x The issue has been fixed in 2.1 release line Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed

Comments

@saurabh-parekh
Copy link

saurabh-parekh commented May 19, 2018 •
edited
Loading

Preconditions

  1. Magento 2.2.4
  2. PHP 7.1.15
  3. MySQL 14.14
  4. Ubuntu

Steps to reproduce

Function is unnecessarily called multiple time.
app/code/Magento/CurrencySymbol/view/adminhtml/templates/grid.phtml

Expected result

<?php $block->getCurrencySymbolsData();?> should be used only single time.

Actual result

<?php $block->getCurrencySymbolsData();?> is used multiple times in the same file.
@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label May 19, 2018
@saurabh-parekh saurabh-parekh mentioned this issue May 19, 2018
Merged
4 tasks
@magento-engcom-team
Copy link
Contributor

Hi @saurabh-aureate. Thank you for your report.
The issue has been fixed in #15346 by @saurabh-aureate in 2.2-develop branch
Related commit(s):

The fix will be available with the upcoming 2.2.5 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label May 22, 2018
This was referenced Jun 4, 2018
Merged
Merged
@sidolov sidolov added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Jun 5, 2018
@sidolov
Copy link
Contributor

sidolov commented Jun 5, 2018

Hi @saurabh-aureate. Thank you for your report.
The issue has been fixed in #15763 by @vgelani in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.0 release.

@gelanivishal gelanivishal mentioned this issue Jul 13, 2018
Merged
4 tasks
@VladimirZaets
Copy link
Contributor

Hi @saurabh-aureate. Thank you for your report.
The issue has been fixed in #16761 by @gelanivishal in 2.1-develop branch
Related commit(s):

The fix will be available with the upcoming 2.1.15 release.

@VladimirZaets VladimirZaets added the Fixed in 2.1.x The issue has been fixed in 2.1 release line label Jul 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Event: dmcdindia Fixed in 2.1.x The issue has been fixed in 2.1 release line Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@VladimirZaets @sidolov @magento-engcom-team @saurabh-parekh