Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Function is unnecessarily called multiple time #15346

Merged

Conversation

saurabh-parekh
Copy link

@saurabh-parekh saurabh-parekh commented May 19, 2018

Function is unnecessarily called multiple time.

Description

getCurrencySymbolsData() is called multiple times in the same file. Remove the extra call of the same function.

Fixed Issues (if relevant)

Issue Number - #15355

Manual testing scenarios

  1. Check the page. Stores > Currency > Currency Symbols

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @saurabh-aureate. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.2.5 release.

Please, consider porting this solution across release lines.
You may use Porting tool to port commits automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants