Table rate shipment is taken from wrong website ID when creating an order through the admin #16604

digikeijs · 2018-07-06T18:35:12Z

Summary of the issue

When I create an order through the admin panel and select my shipping method table rate it takes the shipping rate table from the wrong website ID.

Preconditions

magento 2.2.4, Linux, non sample data

Steps to reproduce

Setup multistore
Setup different table rates per website
Then through the admin create a new order for the second website/store
Select your shipping method and the price will be taken from the first website / store (id1)

Expected result

Table rate prices are taken from the correct website id

Actual result

Shipment price is always taken from the table rate website id 1

magento-engcom-team · 2018-07-06T18:35:15Z

Hi @digikeijs. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

Summary of the issue
Information on your environment
Steps to reproduce
Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me {$VERSION} instance

where {$VERSION} is version tags (starting from 2.2.0+) or develop branches (2.2-develop +).
For more details, please, review the Magento Contributor Assistant documentation.

@digikeijs do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

yes
no

digikeijs · 2018-07-06T18:37:15Z

@magento-engcom-team give me 2.2.4 instance

magento-engcom-team · 2018-07-06T18:37:19Z

Hi @digikeijs. Thank you for your request. I'm working on Magento 2.2.4 instance for you

magento-engcom-team · 2018-07-06T18:37:55Z

Hi @digikeijs, here is your Magento instance.
Admin access: https://i-16604-2-2-4.engcom.dev.magento.com/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

engcom-backlog-nickolas · 2018-07-09T07:37:47Z

Hello @digikeijs, thank you for your report.
We've acknowledged the issue and added to our backlog.

digikeijs · 2018-07-09T08:51:49Z

Thanks a lot, if you have time can you please also look at below issue. Almost the same issue but then related to update qty but also using the wrong website id / store.

#15846

CliftonWLS · 2018-07-11T19:30:43Z

We are having the same issue. Tracked it down to the requestShippingRates() method in \Quote\Model\Quote\Address.php:

$request->setStoreId($this->storeManager->getStore()->getId());
$request->setWebsiteId($this->storeManager->getWebsite()->getId());

Where storeManager is not set with the store that was selected when creating the order. I have tried to override this method but have run into endless issues doing so. Is there anyone that can provide some insight into overriding this method?

callumstar · 2018-09-14T12:41:48Z

Hi @digikeijs,

Did you ever resolve this at all?

callumstar · 2018-09-14T13:50:18Z

Hi @CliftonWLS,

Did you ever manage to succeed in overriding the method at all?

SvanZui · 2018-09-14T13:54:14Z

@callumstar nope still waiting on the magento team to fix it. Do have a workaround but it sucks

callumstar · 2018-09-14T13:56:41Z

Hi @SAPontwerp,

Are you able to share the workaround at all with me please? If it's something then I'd be happy to use it!

callumstar · 2018-09-17T09:25:40Z

Hi @SAPontwerp, did you have a workaround at all? I'm happy to use it no matter how hacky it is.

SvanZui · 2018-09-19T11:06:11Z

@callumstar we do not have that much orders from the admin so we just enable a fixed shipping price when we add an order and turn it off again when done.

Rickertje · 2018-09-24T20:11:11Z

@magento-engcom-team hi guys any idea when this gets fixed (along with maybe #18059 and #12889 and #16604 which are possible duplicates) ?

Rickertje · 2018-10-24T09:28:59Z

Hi guys it has been another month. Can someone give an update?

oleksii-lisovyi · 2018-11-23T13:11:12Z

Hi guys.

Looks like the issue has been fixed in the 2.2-develop branch.
Related commit:
9c066ca

Rickertje · 2018-11-23T14:34:25Z

@oleksii-lisovyi does this mean that this fix will also (by default) be incorporated in 2.3 (and or 2.2.7) ? I'm not a developer so I dont know exactly how this works.

oleksii-lisovyi · 2018-11-23T15:17:18Z

@Rickertje, yes. Having any fix in the develop branch means, that it will be available in one of the next 2.2.x releases and could be ported into 2.3.

oleksii-lisovyi · 2018-11-23T15:18:20Z

I tested the fix I've mentioned previously - it works great. I'm closing the issue.

Rickertje · 2019-01-03T20:26:39Z

@oleksii-lisovyi I have tried this in 2.2.7 but the problem is still there. Please reopen the issue.

oleksii-lisovyi · 2019-01-04T09:25:09Z

@Rickertje, the issue was not fixed in 2.2.7 (probably it will be fixed in the 2.2.8).

But you can apply the fix right now by applying patch via vaimo/composer-patches.

How to apply specific commit/PR from terminal:
0. Install composer by following steps from https://getcomposer.org/download/. After make composer global:

mv composer.phar /usr/local/bin/composer

Install package vaimo/composer-patches:

cd path/to/magento2 && composer require vaimo/composer-patches:4.7.0

Add following section into path/to/magento2/composer.json file:

...
"extra": {
        "magento-force": "override",
        "patches": {
           "magento/module-quote": {
                "Fix issue getting rates while placing order from Admin panel": {
                    "source": "https://github.com/magento/magento2/commit/9c066ca1cc2f2db9e66575da25992ca9bb74f65a.patch",
                    "level": 5
                }
            }
        }
    },
...

Apply patches:

composer install

digikeijs · 2019-03-07T08:19:30Z

Anybody got this working on 2.3? When I want to install this patch I get

 - Applying patches for magento/module-quote (1)
    ~ digikeijs/magento2: https://github.com/magento/magento2/commit/9c066ca1cc2f2db9e66575da25992ca9bb74f65a.patch [NEW]
      Fix issue getting rates while placing order from Admin panel
  [Vaimo\ComposerPatches\Exceptions\PatchFailureException]
  Cannot apply patch /tmp/composer-patches-e54b6815eedfac36ce8b5e9e0554cb6b.patch

oleksii-lisovyi · 2019-03-07T13:01:19Z

Hi, @digikeijs.

The issue is fixed in the 2.3-develop in the commit cc00197.
You can try to apply this commit instead of that one, that is related to 2.2.x.

digikeijs · 2019-03-07T13:04:56Z

Well it's not fixed in 2.3 but found a solution already but will also check your info thanks

oleksii-lisovyi · 2019-03-07T13:24:27Z

@digikeijs, 2.3 is a stable version, but 2.3-develop is a development branch, than usually contains more fixes and improvements comparing to the branch of stable version.
Just try to apply that patch - the fix looks the same as on 2.2.

digikeijs · 2019-03-07T13:34:52Z

Sorry you are right, misread that :-)

digikeijs · 2019-03-07T13:40:30Z

Same problem :-( Processing patches configuration

- Applying patches for magento/module-quote (1)
  ~ digikeijs/magento2: https://github.com/magento/magento2/commit/cc00197d13d6244e32201e4c6bf00287e54747c5.diff [NEW]
    Fix issue getting rates while placing order from Admin panel


[Vaimo\ComposerPatches\Exceptions\PatchFailureException]
Cannot apply patch /tmp/composer-patches-09ece90d8e75d0f6997d6a89f04100b4.patch

oleksii-lisovyi · 2019-03-07T14:25:24Z

There is one more additional commit, that was done before that change.
Please add a patch for the commit b35b681 as well.
This should help.

digikeijs · 2019-03-08T10:15:23Z

Sorry for all the questions, can you help me running multiple patches? Like this it does not work

"extra": {
        "magento-force": "override",
		"patches": {
           "magento/module-quote": {
                "Fix issue getting rates while placing order from Admin panel": {
				    "source": "https://github.com/magento/magento2/commit/b35b68130265163f2ed151ff94e0d9f7fc63d44c.patch",
                    "source": "https://github.com/magento/magento2/commit/cc00197d13d6244e32201e4c6bf00287e54747c5.patch"
                }

oleksii-lisovyi · 2019-03-08T11:26:05Z

No problem. Each patch must contain 1 source. So adding 2 patches for 1 module requires to have following structure:

"extra": {
        "magento-force": "override",
		"patches": {
           "magento/module-quote": {
                "Fix issue getting rates while placing order from Admin panel - part 1": {
				    "source": "https://github.com/magento/magento2/commit/b35b68130265163f2ed151ff94e0d9f7fc63d44c.patch"
                },
"Fix issue getting rates while placing order from Admin panel - part 2": {
				    "source": "https://github.com/magento/magento2/commit/cc00197d13d6244e32201e4c6bf00287e54747c5.patch"
                }
}

Please check on typos, because I'm writing from phone.

oleksii-lisovyi · 2019-03-11T18:12:27Z

Hi, @digikeijs.

Did it help? Do you need a help?

digikeijs · 2019-03-11T18:17:16Z

Thanks for the follow up. No already the first commit gives issues, most likely the content of the file is a bit different. But I like my workaround more, no more patch files, I just replace the files I want to have replaced during composer install. Saves a lot of hassel

		"scripts": {
		"post-install-cmd": [
				"cp -Rfp vendor-patches/. ."

magento-engcom-team added the Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed label Jul 6, 2018

engcom-backlog-nickolas self-assigned this Jul 9, 2018

engcom-backlog-nickolas removed their assignment Jul 9, 2018

engcom-backlog-nickolas added the help wanted label Jul 9, 2018

magento-engcom-team added Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed and removed Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed labels Jul 19, 2018

callumstar mentioned this issue Sep 14, 2018

Magento 2.2.5 - If Multi-Storefront, Shipping Rates on an Admin Order use rates from the default store #18059

Closed

Rickertje mentioned this issue Oct 24, 2018

Wrong shipping fee in backend with multiple store views #12889

Closed

oleksii-lisovyi mentioned this issue Nov 23, 2018

Module Quote: fix issue with incorrect Store & Website ID init for Quote Address Request while getting rates at Admin panel #19361

Closed

4 tasks

oleksii-lisovyi closed this as completed Nov 23, 2018

ghost mentioned this issue Mar 21, 2019

Shipment methods for backend order don't show on multistore setup #21867

Closed

Table rate shipment is taken from wrong website ID when creating an order through the admin #16604

Table rate shipment is taken from wrong website ID when creating an order through the admin #16604

Comments

digikeijs commented Jul 6, 2018 • edited by engcom-backlog-nickolas Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Preconditions

Steps to reproduce

Expected result

Actual result

magento-engcom-team commented Jul 6, 2018

Uh oh!

digikeijs commented Jul 6, 2018

Uh oh!

magento-engcom-team commented Jul 6, 2018

Uh oh!

magento-engcom-team commented Jul 6, 2018

Uh oh!

engcom-backlog-nickolas commented Jul 9, 2018

Uh oh!

digikeijs commented Jul 9, 2018

Uh oh!

CliftonWLS commented Jul 11, 2018

Uh oh!

callumstar commented Sep 14, 2018

Uh oh!

callumstar commented Sep 14, 2018

Uh oh!

SvanZui commented Sep 14, 2018

Uh oh!

callumstar commented Sep 14, 2018

Uh oh!

callumstar commented Sep 17, 2018

Uh oh!

SvanZui commented Sep 19, 2018

Uh oh!

Rickertje commented Sep 24, 2018

Uh oh!

Rickertje commented Oct 24, 2018

Uh oh!

oleksii-lisovyi commented Nov 23, 2018

Uh oh!

Rickertje commented Nov 23, 2018

Uh oh!

oleksii-lisovyi commented Nov 23, 2018

Uh oh!

oleksii-lisovyi commented Nov 23, 2018

Uh oh!

Rickertje commented Jan 3, 2019

Uh oh!

oleksii-lisovyi commented Jan 4, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

digikeijs commented Mar 7, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

oleksii-lisovyi commented Mar 7, 2019

Uh oh!

digikeijs commented Mar 7, 2019

Uh oh!

oleksii-lisovyi commented Mar 7, 2019

Uh oh!

digikeijs commented Mar 7, 2019

Uh oh!

digikeijs commented Mar 7, 2019

Uh oh!

oleksii-lisovyi commented Mar 7, 2019

Uh oh!

digikeijs commented Mar 8, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

oleksii-lisovyi commented Mar 8, 2019

Uh oh!

oleksii-lisovyi commented Mar 11, 2019

Uh oh!

digikeijs commented Mar 11, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

digikeijs commented Jul 6, 2018 •

edited by engcom-backlog-nickolas

Loading

oleksii-lisovyi commented Jan 4, 2019 •

edited

Loading

digikeijs commented Mar 7, 2019 •

edited

Loading

digikeijs commented Mar 8, 2019 •

edited

Loading

digikeijs commented Mar 11, 2019 •

edited

Loading