-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configurable Product Image Parent Product Thumbnail not working #17174
Comments
Hi @willwright111. Thank you for your report.
Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:
where @willwright111 do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?
|
@willwright111, thank you for your report. |
It seems that fix #8168 added in Magento 2.2.5 introduced this issue. My proposed solution is to change lines 125-130 of vendor/magento/module-catalog/Block/Product/ImageBuilder.php to the following:
` Not sure if this is the best approach, but it's working for now. |
@willwright111 Related commit(s): |
@ronak2ram Thanks for the reply. I thought lines 125-130 of ImageBuilder.php are supposed to fix #8168. It appears that the commit you referenced (108c2c5) breaks support for this. I believe that it is still supposed to be getCustomOption instead of getOptionById to be able to display the variation's image (if present). I think getOptionById() is a method for products with custom options setup, not configurable products. However, there still needs to be a check if the variation even has a product image prior to using it as the Cart\Wishlist's image. |
@numan201 You right, |
@ronak2ram, what're your thoughts on the potential solution I posted earlier? |
@ronak2ram My solution seems to be working fine on the cart page for me. |
You checked with both option ?
Check pages Cart page, Mini cart, Wishlist with both option. If you solution work than you can create pull request for magento developer and developer will be test your code. |
Would it be a good solution to check first |
Noticing the same problem -- same preconditions and actual results: Parent image visible in minicart and checkout, but child image displaying on cart page, despite Configuration settings as "Configurable Product Image" 1. Parent Product Thumbnail |
Reproduced on 2.2.5 |
Appears to be resolved in 2.2.6 with pull request #16863 |
Hello @willwright111 @kevinvarley @BubblegumAnarchy As we can see from the comment above #17174 (comment) this issue is fixed in #16863 It is available in 2.2-develop now and should be availabe in 2.2.6 This ticket can be closed. Thank you for feedback and collaboration |
Preconditions
Magento 2.2.5 Community
PHP 7.1
Server Apache
Steps to reproduce
Expected result
Actual result
Product images displaying is inconsistent on Mini-Cart, Shopping Cart and Checkout.
The text was updated successfully, but these errors were encountered: