Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable Product with Only Size Options (No Color Options) Shows … #16863

Merged
merged 2 commits into from
Jul 23, 2018
Merged

Configurable Product with Only Size Options (No Color Options) Shows … #16863

merged 2 commits into from
Jul 23, 2018

Conversation

ronak2ram
Copy link
Member

Description

Function getCustomOption() not working well for configurable product.
So I replace getCustomOption to getOptionById. than its work fine.

Fixed Issues

  1. Magento 2.2.5: Configurable Product with Only Size Options (No Color Options) Shows No Image in Cart #16843: Magento 2.2.5: Configurable Product with Only Size Options (No Color Options) Shows No Image in Cart.

Manual testing scenarios

  1. Set in admin: Stores > Configuration > Sales > Checkout > Shopping Cart: "Configurable Product Image: Parent Product Thumbnail"
  2. Create a configurable product with multiple size options, but no color options.
  3. Assign an image(s) only to the configurable product (not to child/simple products)
  4. Visit the product page in the store front and add it to cart.

Result

Product image should show on cart page (coming from configurable product)

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @ronak2ram. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@ronak2ram
Copy link
Member Author

@nuzil
Have you checked this solution?

@nuzil nuzil removed their assignment Jul 20, 2018
@nuzil nuzil self-requested a review July 20, 2018 06:18
Copy link
Contributor

@nuzil nuzil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ronak2ram thanks a lot for your solution!

@magento-engcom-team
Copy link
Contributor

Hi @nuzil, thank you for the review.
ENGCOM-2383 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

Hi @ronak2ram. Thank you for your contribution.
We will aim to release these changes as part of 2.2.6.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

@nmalevanec
Copy link
Contributor

Is nothing to forwardport due to MAGETWO-75086. This code changes no longer exist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants