Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update UI so modal doesn't show when cache clear is needed #1769

Closed
markshust opened this issue Aug 31, 2015 · 8 comments
Closed

Update UI so modal doesn't show when cache clear is needed #1769

markshust opened this issue Aug 31, 2015 · 8 comments
Labels
Component: Framework/Cache Fixed in 2.4.x The issue has been fixed in 2.4-develop branch improvement Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development

Comments

@markshust
Copy link
Contributor

There are two "One or more of the Cache Types are invalidated" messages that appear when a cache clear is needed.

screen shot 2015-08-31 at 9 42 13 am

I don't see the purpose of the modal prompting, and then when closing the modal, still seeing the alert at the top of the screen.

The modal is redundant. I believe this should be removed, and stick with the "M1" way of the prompts by just displaying the message at the top of the screen. It's plenty apparent the cache needs to be cleared. Having to close the modal every time is also very cumbersome and annoying...

screen shot 2015-08-31 at 9 43 35 am
@netorica
Copy link

+1

@MomotenkoNatalia
Copy link
Contributor

Internal reference: MAGETWO-37976
Thanks for reporting this issue!

@vpelipenko vpelipenko added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development PS bug report labels Sep 1, 2015
@markshust
Copy link
Contributor Author

I don't think this issue was ever resolved, as it still exists in 2.0.0.

@markshust
Copy link
Contributor Author

@MomotenkoNatalia since 2.0.0 is released, are tickets still handled internally or is everything on github now? I wasn't sure if this was being resolved (because you have an internal ticket number noted), or if you were taking PR's for stuff like this. Lmk. Thanks!

@sshrewz
Copy link

sshrewz commented Mar 17, 2016

@markoshust, there was a misunderstanding. Internal ticket should be MAGETWO-43718.

@sshrewz sshrewz added MX and removed PS labels Mar 17, 2016
@vkorotun
Copy link
Contributor

vkorotun commented Aug 4, 2016 •
edited
Loading

There is related internal ticket in progress now MAGETWO-50670 that need to address issue with automated caches flushes without displaying modals/notifications (especially in developer/default modes). We will check this one if it still valid and will fix it if so.

@piotrekkaminski
Copy link
Contributor

Thank you for your submission.

We recently made some changes to the way we process GitHub submissions to more quickly identify and respond to core code issues.

Feature Requests and Improvements should now be submitted to the new Magento 2 Feature Requests and Improvements forum (see details here).

We are closing this GitHub ticket and have moved your request to the new forum.

okorshenko pushed a commit that referenced this issue Nov 27, 2017
Merge pull request #1769 from magento-engcom/2.2-develop-prs
3d628f8 
Public Pull Requests

#1770 9515: South Korea Zip Code Validation incorrect by @RomaKis
#12132 10210: Transport variable can not be altered in email_invoice_set_template_vars_before Event (backport MAGETWO-69482 to 2.2) by @RomaKis

Fixed Public Issues

#9515 South Korea Zip Code Validation incorrect
#10210 Transport variable can not be altered in email_invoice_set_template_vars_before Event
@magento-engcom-team
Copy link
Contributor

Hi @markoshust. Thank you for your report.
The issue has been fixed in #29684 by @Nazar65 in 2.4-develop branch
Related commit(s):

The fix will be available with the upcoming 2.4.2 release.

@magento-engcom-team magento-engcom-team added Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed labels Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: Framework/Cache Fixed in 2.4.x The issue has been fixed in 2.4-develop branch improvement Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@markshust @piotrekkaminski @vpelipenko @vkorotun @rgoncharuk @MomotenkoNatalia @sshrewz @magento-engcom-team