Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Postcode / Zipcode in checkout form already validated on page load #18630

Closed
dverkade opened this issue Oct 15, 2018 · 14 comments
Closed

Postcode / Zipcode in checkout form already validated on page load #18630

dverkade opened this issue Oct 15, 2018 · 14 comments
Labels
Component: Checkout Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@dverkade
Copy link
Member

dverkade commented Oct 15, 2018

Preconditions

  1. Magento 2.2.6

Related issues

There are several bugs about this, but they are all closed and it's mentioned that this has been resolved in Magento 2.2.X, but unfortunately it's not in the latest version, so opening a new bug report for this issue.

  1. Checkout: ZIP code in shipping address form already validated on page load #7724
  2. Zip / postcode has a default value of * in the checkout #8115

Steps to reproduce (*)

  1. Add products to cart
  2. Checkout as a guest
  3. The tax/defaults/postcode config value in core_config_data is NULL

Expected result (*)

  1. Postcode / Zipcode field should be empty and should not be validated
  2. No error message should be shown that the field is required

Actual result (*)

  1. Postcode / Zipcode field has error message that the field is required

image

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Oct 15, 2018
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Oct 15, 2018

Hi @dverkade. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me $VERSION instance

where $VERSION is version tags (starting from 2.2.0+) or develop branches (for example: 2.3-develop).
For more details, please, review the Magento Contributor Assistant documentation.

@dverkade do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

dverkade added a commit that referenced this issue Oct 15, 2018
@ghost ghost self-assigned this Oct 29, 2018
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Oct 29, 2018

Hi @engcom-backlog-nazar. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 6. Add label Issue: Confirmed once verification is complete.

  • 7. Make sure that automatic system confirms that report has been added to the backlog.

@ghost ghost added the Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed label Oct 29, 2018
@ghost
Copy link

ghost commented Oct 29, 2018

HI @dverkade thank you for your report, i'm confusing with your issue, why zip code must be not required ? after you chose tax/default/postcode ? because this field is required -> Settings can be found in: Admin Panel > Stores > Settings > Configuration > General > General > Country options > Zip/Postal Code is Optional for .
So if you chose all you dont have this error validation. And why taxes can remove validation from aip postal code ?

@ghost
Copy link

ghost commented Oct 29, 2018

@dverkade Ok, i'm understand that if page load, then this validate the zip code filed, but in my case i have no validation, see attachments.
zip

@dverkade
Copy link
Member Author

@engcom-backlog-nazar if I look at the screenshots you are using Magento 2.3 development. As noted in the issue description we have this issue with Magento 2.2.6.

@ghost
Copy link

ghost commented Oct 29, 2018

@dverkade ok, but you created the PR #18633 to 2.3-develop so this issue must be in 2.3 ?

@ghost
Copy link

ghost commented Oct 29, 2018

@dverkade the same on 2.2-develop and 2.2.6 instance, i'm do exactly what you mentioned on steps to reproduce.

@ghost
Copy link

ghost commented Oct 29, 2018

@dverkade Can you reproduce this on vanilla instance ?

@ghost
Copy link

ghost commented Nov 12, 2018

@dverkade, we are closing this issue due to inactivity. If you'd like to update it, please reopen the issue.

@ghost ghost closed this as completed Nov 12, 2018
@ghost ghost reopened this Nov 29, 2018
@ghost
Copy link

ghost commented Nov 29, 2018

I'm able to reproduced this issue by following steps on 2.2-develop and 2.3-develop:

  1. Use system value to : Stores > Settings > Configuration > General > General > Country options > Zip/Postal Code is Optional for
  2. Add products to cart as guest
  3. Proceed to checkout

@ghost ghost added Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Nov 29, 2018
@magento-engcom-team magento-engcom-team removed the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Nov 29, 2018
@magento-engcom-team
Copy link
Contributor

@engcom-backlog-andrii Thank you for verifying the issue.

Unfortunately, not enough information was provided to created internal ticket. Please consider adding the following:

  • Add "Component: " label(s) to this ticket based on verification result. If uncertain, you may follow the best guess

Once all required information is added, please add label "Issue: Confirmed" again.
Thanks!

@ghost ghost added Component: Checkout Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Nov 29, 2018
@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Nov 29, 2018
@magento-engcom-team
Copy link
Contributor

@engcom-backlog-andrii Thank you for verifying the issue. Based on the provided information internal tickets MAGETWO-96736, MAGETWO-96737 were created

@ghost ghost removed the Progress: needs update label Dec 5, 2018
@ghost ghost removed their assignment Dec 5, 2018
@PathToLife
Copy link
Member

PathToLife commented Jan 7, 2019

Can also reproduce..

Still exists in 2.3.0. Just have to set a postcode in "Default Tax Destination Calculation"

Which is set here:
http://Base_url/admin/admin/system_config/edit/section/tax/
postcode set here

Use Xdebug in any active shipping module on calling RateRequest->getDestPostcode(). We observe that:

Magento\Quote\Model\Quote\Address\RateRequest->$_data['dest_postcode'] = Default Tax Destination Calculation

@magento-engcom-team
Copy link
Contributor

Hi @dverkade. Thank you for your report.
The issue has been fixed in #18633 by @dverkade in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.2 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Checkout Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

No branches or pull requests

3 participants