Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue magento/magento2#18630 #18632

Conversation

dverkade
Copy link
Member

Description (*)

When in the core_config_data table the setting for tax/defaults/postcode is NULL the compare on the frontend is breaking because NULL != " ". This fix resolves that issue.

Fixed Issues

  1. Postcode / Zipcode in checkout form already validated on page load  #18630: Postcode / Zipcode in checkout form already validated on page load

Manual testing scenarios (*)

See steps in issue to reproduce original issue.

@magento-engcom-team
Copy link
Contributor

Hi @dverkade

Unfortunately, we cannot accept Pull Requests from branches created in magento2 repository.
Please use your own fork as a base for this Pull Request.

Thank you.

@magento-engcom-team
Copy link
Contributor

Hi @dverkade. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@okorshenko okorshenko deleted the 18630-Postcode-Zipcode-in-checkout-form-already-validated-on-page-load branch October 22, 2018 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants