Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Link is not correctly shown as Current if contains default parts #19099

Closed
eduard13 opened this issue Nov 7, 2018 · 10 comments
Closed

New Link is not correctly shown as Current if contains default parts #19099

eduard13 opened this issue Nov 7, 2018 · 10 comments
Assignees
Labels
Component: Framework/View Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@eduard13
Copy link
Contributor

eduard13 commented Nov 7, 2018

Preconditions (*)

  1. Magento 2.2.6, 2.3

Steps to reproduce (*)

  1. Add a new link to the customer account navigation using layouts
  2. For path use the default part index, example: vault/index/index/
<block class="Magento\Framework\View\Element\Html\Link\Current" name="demo-link">
  <arguments>
          <argument name="path" xsi:type="string">vault/index/index/</argument>
          <argument name="label" xsi:type="string">Demo Link</argument>
          <argument name="sortOrder" xsi:type="number">161</argument>
   </arguments>
</block>
  1. Open the customer dashboard
  2. Go to the new added link (Demo Link)

Expected result (*)

  1. The link is marked as current
    05187bc0cb

Actual result (*)

  1. The new added link isn't marked as current link
    1a4e46c02f
@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Nov 7, 2018
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Nov 7, 2018

Hi @eduard13. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me $VERSION instance

where $VERSION is version tags (starting from 2.2.0+) or develop branches (for example: 2.3-develop).
For more details, please, review the Magento Contributor Assistant documentation.

@eduard13 do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@eduard13 eduard13 assigned eduard13 and unassigned eduard13 Nov 7, 2018
@vasilii-b
Copy link

vasilii-b commented Nov 7, 2018

@magento-engcom-team give me 2.2-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @vasilii-b. Thank you for your request. I'm working on Magento 2.2-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @vasilii-b, here is your Magento instance.
Admin access: http://34.228.235.121/i-19099-2-2-develop//admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@vasilii-b vasilii-b added Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Nov 7, 2018
@vasilii-b vasilii-b self-assigned this Nov 7, 2018
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Nov 7, 2018

Hi @vasilii-b. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 6. Add label Issue: Confirmed once verification is complete.

  • 7. Make sure that automatic system confirms that report has been added to the backlog.

@vasilii-b vasilii-b added Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Component: Framework/View Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Nov 7, 2018
@magento-engcom-team
Copy link
Contributor

@vasilii-b Thank you for verifying the issue. Based on the provided information internal tickets MAGETWO-96189, MAGETWO-96190 were created

@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Nov 7, 2018
@vasilii-b vasilii-b removed their assignment Nov 7, 2018
@magento-engcom-team magento-engcom-team added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Dec 19, 2018
@sidolov
Copy link
Contributor

sidolov commented Jan 14, 2019

Hi @eduard13. Thank you for your report.
The issue has been fixed in #19927 by @eduard13 in 2.2-develop branch
Related commit(s):

The fix will be available with the upcoming 2.2.8 release.

@sidolov sidolov added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Jan 14, 2019
@eduard13
Copy link
Contributor Author

@magento-engcom-team give me 2.2-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @eduard13. Thank you for your request. I'm working on Magento 2.2-develop instance for you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Framework/View Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

No branches or pull requests

4 participants