Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] [Framework] New Link is not correctly shown as Current if contains default parts #19927

Merged

Conversation

eduard13
Copy link
Contributor

Original Pull Request

#19134

Description (*)

This PR fixes the logic of isCurrent method by comparing the current requested url with the link path. This way we'll always know if the link is current, even it uses some index default parts.

Fixed Issues (if relevant)

  1. New Link is not correctly shown as Current if contains default parts #19099: New Link is not correctly shown as Current if contains default parts

Manual testing scenarios (*)

  1. Add a new link to customer account navigation menu
  2. Navigate to the new added link
  3. The link should have active state in the sidebar
    7bec67d2e5

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @eduard13. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team magento-engcom-team added Component: Framework/View Release Line: 2.2 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Dec 21, 2018
@eduard13 eduard13 requested a review from rogyar December 21, 2018 14:12
@magento-engcom-team magento-engcom-team added this to the Release: 2.2.8 milestone Dec 24, 2018
@ghost
Copy link

ghost commented Jan 14, 2019

Hi @eduard13, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Jan 14, 2019
@magento-engcom-team
Copy link
Contributor

Hi @eduard13. Thank you for your contribution.
We will aim to release these changes as part of 2.2.8.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Framework/View Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants