[Framework] New Link is not correctly shown as Current if contains default parts

[eduard13]

Description (*)

This PR fixes the logic of isCurrent method by comparing the current requested url with the link path. This way we'll always know if the link is current, even it uses some index default parts.

Fixed Issues (if relevant)

1. New Link is not correctly shown as Current if contains default parts #19099: New Link is not correctly shown as Current if contains default parts

Manual testing scenarios (*)

1. Add a new link to customer account navigation menu
2. Navigate to the new added link
3. The link should have active state in the sidebar
   

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[magento-engcom-team]

Hi @eduard13. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[rogyar]

This change might be harmful since we stop using getMca() method at all. That means that we can have the current links functionality broken in different places. I would recommend adding an additional check here (by trimming /index/index or so) instead of removing invoking of getMca() method

[eduard13]

@rogyar thank you for suggestion, currently the logic of the getMca method was improved, by removing the _defaultPath logic (which was wrong in my opinion). Also there are covered all the cases when a default url part is used.

So having a new link test/index, the following possible cases will mark this link as Current:

• test
• test/index
• test/index/index

[rogyar]

Have you tested passing GET parameters via URL as well?

[eduard13]

Yes, with all these cases - the link keeps its current state.

[eduard13]

@rogyar is there anything else that I can do here?
Thank you.

[magento-engcom-team]

Hi @eduard13. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.