Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can only export default store view items when upgrade to 2.3.0 #19786

Closed
Yuwei9291 opened this issue Dec 15, 2018 · 20 comments
Closed

Can only export default store view items when upgrade to 2.3.0 #19786

Yuwei9291 opened this issue Dec 15, 2018 · 20 comments
Assignees
Labels
Component: ImportExport Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@Yuwei9291
Copy link

Yuwei9291 commented Dec 15, 2018

Component: ImportExport

Preconditions (*)

1.Nginx 1.14.0 + PHP 7.1.24 + MySQL5.7.19
2.Clean install Magento 2.2.6 and upgrade to 2.3.0 by command.
3.

Steps to reproduce (*)

1.Clean install Magento 2.2.6 without any unnecessary module.
2.Creat a new Website with a new store and a new store view "storeview2".
3.Upload a item with different price in different store view. Now the product export file is correct with 2 rows.
4.Upgrade to 2.3.0, now the exported file have only 1 row and do not have the price information of "storeview2"

Expected result (*)

  1. Exported file should have 2 rows , row 1 should be the information of All store view, row 2 should be the price of "storeview2"

Actual result (*)

  1. The file have only 1 row with All store view information. and lost the price information of "storeview2"
@magento-engcom-team
Copy link
Contributor

Hi @Yuwei9291. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me $VERSION instance

where $VERSION is version tags (starting from 2.2.0+) or develop branches (for example: 2.3-develop).
For more details, please, review the Magento Contributor Assistant documentation.

@Yuwei9291 do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Dec 15, 2018
@developerarun developerarun self-assigned this Dec 15, 2018
@magento-engcom-team
Copy link
Contributor

Hi @developerarun. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 6. Add label Issue: Confirmed once verification is complete.

  • 7. Make sure that automatic system confirms that report has been added to the backlog.

@ghost ghost self-assigned this Dec 18, 2018
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Dec 18, 2018

Hi @engcom-backlog-nazar. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 6. Add label Issue: Confirmed once verification is complete.

  • 7. Make sure that automatic system confirms that report has been added to the backlog.

@ghost ghost added Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Component: ImportExport Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Fixed in 2.2.x The issue has been fixed in 2.2 release line Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Dec 18, 2018
@magento-engcom-team
Copy link
Contributor

@engcom-backlog-nazar Thank you for verifying the issue. Based on the provided information internal tickets MAGETWO-97206 were created

@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Dec 18, 2018
@ghost ghost removed their assignment Dec 18, 2018
@Nazar65 Nazar65 self-assigned this Dec 22, 2018
@magento-engcom-team
Copy link
Contributor

Hi @Nazar65. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if your want to validate it one more time, please, go though the following instruction:

  • 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 2. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 3. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 4. If the issue is not relevant or is not reproducible any more, feel free to close it.

@Yuwei9291
Copy link
Author

can anyone solve this issue ? many thanks !

@allozaur
Copy link

@magento-engcom-team this issue is relevant for many Magento store owners/developers - me included

Even if i upload CSV file, having each of the positions having row for each store view (default (pln), eur, usd and gbp in my case), then after clicking System > Data Transfer > Export > Products then i get just the CSV with my products for the default store view, loosing all the rows for other store views

Attached Screenshots

This is a screenshot of a part of CSV that was imported to Magento

zrzut ekranu 2019-01-20 o 00 17 50

On this screenshot there are the same products as below but from the exported CSV from the same Magento instance just moment after importing the data from previous screenshot

zrzut ekranu 2019-01-20 o 00 21 11

@Nazar65
Copy link
Member

Nazar65 commented Jan 19, 2019

Hi @Yuwei9291 @allozaur I'm working on this

@allozaur
Copy link

@Nazar65 great to hear that! Do you have any time estimate for this issue to be closed?

@Nazar65
Copy link
Member

Nazar65 commented Jan 21, 2019

@allozaur yes , i will provide a PR soon

@Nazar65
Copy link
Member

Nazar65 commented Jan 22, 2019

@allozaur I'm finally found the problem, this is very simple fix :)

@allozaur
Copy link

allozaur commented Jan 22, 2019

@Nazar65 oh, i see - it looks really simple :)

@Nazar65
Copy link
Member

Nazar65 commented Jan 22, 2019

@allozaur on file -> app/code/Magento/CatalogImportExport/Model/Export/Product.php move LINE 952
$collection->clear(); to LINE 951

So after each iteration we have new collection. this was casued by https://github.com/magento-engcom/magento2ce/commit/461009ef7492cae1ca17183fac5b26d142b6e01f

@allozaur
Copy link

@Nazar65 it seems not to fix our problem, any other ideas?

@Nazar65
Copy link
Member

Nazar65 commented Jan 28, 2019

@allozaur hmm... strange, can you please provide screenshot of sample export csv ? you can deploy test instance on the my PR and recheck ?
@magento-engcom-team give me test instance

selection_294

@Nazar65
Copy link
Member

Nazar65 commented Jan 28, 2019

@allozaur did you set Catalog Price Scope -> website ?

@swnsma
Copy link
Contributor

swnsma commented Jan 28, 2019

The fix #19395.

@allozaur
Copy link

@Nazar65 yes, of course

zrzut ekranu 2019-01-31 o 03 19 49

@allozaur
Copy link

@Nazar65 Ok issue is solved for us!! We had some complications with the deploy process and the modified files weren't being recognized properly. Thanks a lot for your help!

@magento-engcom-team
Copy link
Contributor

Hi @Yuwei9291. Thank you for your report.
The issue has been fixed in #19395 by @Valant13 in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.2 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Feb 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: ImportExport Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

No branches or pull requests

6 participants