Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix-issue-19786 Can only export default store view items when upgrade to 2.3.0 #20465

Closed
wants to merge 1 commit into from

Conversation

Nazar65
Copy link
Member

@Nazar65 Nazar65 commented Jan 22, 2019

Description (*)

Even if i upload CSV file, having each of the positions having row for each store view (default (pln), eur, usd and gbp in my case), then after clicking System > Data Transfer > Export > Products then i get just the CSV with my products for the default store view, loosing all the rows for other store views

Fixed Issues (if relevant)

  1. Can only export default store view items when upgrade to 2.3.0 #19786: Issue title
  2. ...

Manual testing scenarios (*)

1.Clean install Magento 2.2.6 without any unnecessary module.
2.Creat a new Website with a new store and a new store view "storeview2".
3.Upload a item with different price in different store view. Now the product export file is correct with 2 rows.
4.Upgrade to 2.3.0, now the exported file have only 1 row and do not have the price information of "storeview2"

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @Nazar65. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@Nazar65
Copy link
Member Author

Nazar65 commented Jan 23, 2019

Hi @swnsma any updates on this ?

@Nazar65 Nazar65 requested a review from orlangur January 24, 2019 15:28
@Nazar65
Copy link
Member Author

Nazar65 commented Jan 28, 2019

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @Nazar65. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @Nazar65, here is your new Magento instance.
Admin access: https://pr-20465.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@swnsma
Copy link
Contributor

swnsma commented Jan 28, 2019

Hello @Nazar65,

I am sorry for delay.
Unfortunately, there is already the PR #19395 with the same changes which was created much earlier.

Thank you for your contribution and for your time.

@swnsma swnsma closed this Jan 28, 2019
@ghost
Copy link

ghost commented Jan 28, 2019

Hi @Nazar65, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@Nazar65
Copy link
Member Author

Nazar65 commented Jan 28, 2019

@swnsma but seems like this PR is has no activity ? maybe proceed this one ?

@swnsma
Copy link
Contributor

swnsma commented Jan 28, 2019

@Nazar65 I will check with reviewer of that PR.
If there any troubles with that PR, I will re-open and proceed with this.

@Nazar65
Copy link
Member Author

Nazar65 commented Jan 28, 2019

@swnsma Thanks a lot, I'm just worried about delivering this fix to the mainline

@swnsma
Copy link
Contributor

swnsma commented Jan 30, 2019

Hi @Nazar65
I have re-checked this question with maintainer who was reviewed the issue.
There was bug in authorization and he re-pushed PR #19395 for testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants