Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

store_view_code-column-has-empty-values-in-csv-17784. #19395

Conversation

Valant13
Copy link
Contributor

@Valant13 Valant13 commented Nov 24, 2018

Description (*)

Moved ->clear();

Fixed Issues (if relevant)

  1. store_view_code column has empty values in csv #17784: store_view_code column has empty values in csv
  2. Can only export default store view items when upgrade to 2.3.0 #19786: Can only export default store view items when upgrade to 2.3.0

Manual testing scenarios (*)

  1. Go to Back Office
  2. System > Data Transfer > Export
  3. Choose:
    3.1. Entity Type = Products
    3.2. Export File Format = CSV
  4. Press 'Continue" button at the botom of the page
  5. store_view_code column should contain data from product chosen store.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Nov 24, 2018

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team
Copy link
Contributor

Hi @Valant13. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@orlangur orlangur self-assigned this Nov 24, 2018
@swnsma swnsma added partners-contribution Pull Request is created by Magento Partner Partner: ISM eCompany Pull Request is created by partner ISM eCompany labels Nov 25, 2018
@sivaschenko
Copy link
Member

@Valant13 please sign the Contributor License Agreement for us to be able to process this pull request further

@sivaschenko sivaschenko self-assigned this Nov 26, 2018
@orlangur
Copy link
Contributor

@sivaschenko no need to duplicate what the bot is saying ;)

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Jan 28, 2019
@magento-engcom-team
Copy link
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-3993 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

@Valant13 thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@ghost
Copy link

ghost commented Feb 24, 2019

Hi @Valant13, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants