Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email Template Information Insert Variable popup blank #20111

Closed
priti2jcommerce opened this issue Jan 8, 2019 · 21 comments · Fixed by #22469
Closed

Email Template Information Insert Variable popup blank #20111

priti2jcommerce opened this issue Jan 8, 2019 · 21 comments · Fixed by #22469
Assignees
Labels
Component: Email Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@priti2jcommerce
Copy link
Contributor

Preconditions (*)

  1. 2.3.0

Steps to reproduce (*)

  1. Go to admin>>MARKETING>>Email Templates>> edit the template

Expected result (*)

image

Actual result (*)

image

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Jan 8, 2019
@magento-engcom-team
Copy link
Contributor

Hi @priti2jcommerce. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me $VERSION instance

where $VERSION is version tags (starting from 2.2.0+) or develop branches (for example: 2.3-develop).
For more details, please, review the Magento Contributor Assistant documentation.

@priti2jcommerce do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@priti2jcommerce
Copy link
Contributor Author

Hi
@magento-engcom-team give me 2.3-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @priti2jcommerce. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@ghost ghost self-assigned this Jan 8, 2019
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Jan 8, 2019

Hi @engcom-backlog-nazar. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 6. Add label Issue: Confirmed once verification is complete.

  • 7. Make sure that automatic system confirms that report has been added to the backlog.

@ghost ghost added Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Component: Email labels Jan 8, 2019
@ghost
Copy link

ghost commented Jan 8, 2019

HI @priti2jcommerce thank you for you report, i'm not able to reproduce following steps you described, this may be related to your custom modules
selection_256

@ghost ghost closed this as completed Jan 8, 2019
@priti2jcommerce
Copy link
Contributor Author

Hi @engcom-backlog-nazar ,

this issue not with creating new one, this is with editing the existing email template.
I have created one template and try to edit but the pop-up showing blank

@ghost ghost reopened this Jan 8, 2019
@ghost ghost added Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Jan 8, 2019
@magento-engcom-team
Copy link
Contributor

@engcom-backlog-nazar Thank you for verifying the issue. Based on the provided information internal tickets MAGETWO-97482 were created

@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Jan 8, 2019
@ghost ghost removed their assignment Jan 8, 2019
@priti2jcommerce priti2jcommerce self-assigned this Jan 8, 2019
@mahesh-rajawat mahesh-rajawat self-assigned this Jan 9, 2019
@magento-engcom-team
Copy link
Contributor

Hi @maheshWebkul721. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if your want to validate it one more time, please, go though the following instruction:

  • 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 2. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 3. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 4. If the issue is not relevant or is not reproducible any more, feel free to close it.

mahesh-rajawat added a commit to mahesh-rajawat/magento2 that referenced this issue Jan 9, 2019
@mahesh-rajawat mahesh-rajawat mentioned this issue Jan 9, 2019
4 tasks
@priti2jcommerce priti2jcommerce removed their assignment Jan 21, 2019
@priti2jcommerce
Copy link
Contributor Author

@magento-engcom-team give me 2.2-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @priti2jcommerce. Thank you for your request. I'm working on Magento 2.2-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @priti2jcommerce, here is your Magento instance.
Admin access: https://i-20111-2-2-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@shikhamis11 shikhamis11 self-assigned this Jan 24, 2019
@magento-engcom-team
Copy link
Contributor

Hi @shikhamis11. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if your want to validate it one more time, please, go though the following instruction:

  • 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 2. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 3. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 4. If the issue is not relevant or is not reproducible any more, feel free to close it.

@shikhamis11
Copy link
Member

@magento-engcom-team give me 2.3-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @shikhamis11. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@shikhamis11
Copy link
Member

@magento-engcom-team give me 2.3-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @shikhamis11. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @shikhamis11, here is your Magento instance.
Admin access: https://i-20111-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@hapablap
Copy link

To fix this issue by your own, until an update is provided:
The source of the bug is in vendor/magento/module-variable/view/adminhtml/web/variables.js, line 53. The iteration on variables fails. You only need to change this single line from
variables.each(function (variableGroup) {
to
jQuery.each(variables, function (index, variableGroup) {

Of course, you should not edit files in the vendor folder. So you need to override it. To learn how to override a core js file, please refer to https://magento.stackexchange.com/a/60667

@Zyles
Copy link

Zyles commented Mar 12, 2019

variableGroup

Not found in vendor/magento/module-variable/view/adminhtml/web/variables.js

Correct file is vendor/magento/module-email/view/adminhtml/web/js/variables.js

@ghost ghost assigned mahesh-rajawat Mar 28, 2019
mahesh-rajawat added a commit to mahesh-rajawat/magento2 that referenced this issue Apr 1, 2019
@shikhamis11 shikhamis11 removed their assignment Apr 10, 2019
@ghost ghost unassigned mahesh-rajawat Apr 22, 2019
@Bartlomiejsz Bartlomiejsz self-assigned this Apr 23, 2019
@m2-assistant
Copy link

m2-assistant bot commented Apr 23, 2019

Hi @Bartlomiejsz. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

  • 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 2. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 3. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 4. If the issue is not relevant or is not reproducible any more, feel free to close it.

Bartlomiejsz added a commit to Bartlomiejsz/magento2 that referenced this issue Apr 23, 2019
Bartlomiejsz added a commit to Bartlomiejsz/magento2 that referenced this issue Apr 24, 2019
@magento-engcom-team magento-engcom-team added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Apr 27, 2019
@magento-engcom-team
Copy link
Contributor

Hi @priti2jcommerce. Thank you for your report.
The issue has been fixed in #22469 by @Bartlomiejsz in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.2 release.

magento-engcom-team added a commit that referenced this issue Apr 27, 2019
…isting email template #22469

 - Merge Pull Request #22469 from Bartlomiejsz/magento2:feature/fix_20111_email_template_variables
 - Merged commits:
   1. 7d584ac
magento-engcom-team added a commit that referenced this issue Apr 27, 2019
…isting email template #22469

 - Merge Pull Request #22469 from Bartlomiejsz/magento2:feature/fix_20111_email_template_variables
 - Merged commits:
   1. 7d584ac
   2. 4f6a15a
magento-engcom-team added a commit that referenced this issue Apr 27, 2019
…isting email template #22469

 - Merge Pull Request #22469 from Bartlomiejsz/magento2:feature/fix_20111_email_template_variables
 - Merged commits:
   1. 7d584ac
   2. 4f6a15a
   3. 65a61a5
magento-engcom-team pushed a commit that referenced this issue Apr 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Email Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants