Fix #20111 - display variables in popup while editing existing email template

[Bartlomiejsz]

Description (*)

In this PR I tried to fix #20111 after it was probably abandoned.

Fixed Issues (if relevant)

1. Email Template Information Insert Variable popup blank  #20111: Email Template Information Insert Variable popup blank

Manual testing scenarios (*)

1. Go to admin >> MARKETING >> Email Templates
2. Edit existing template
3. Check Insert variable popup if it contains variables

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[m2-assistant]

Hi @Bartlomiejsz. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[magento-engcom-team]

Hi @orlangur, thank you for the review.
ENGCOM-4812 has been created to process this Pull Request

[soleksii]

Hi @Bartlomiejsz !

Your fix provides next problem: Fatal Error message after insert variable to template

Steps to reproduce:

1. Login to Admin;
2. Go to Marketing->Communications->Email Templates;
3. Click on "Add New Template" button;
4. Select "New Account" template from the list for example;
5. Click on "Load Template" button;
6. Fill all required fields;
7. Click on "Save Template" button;
8. Click on created before template for edit;
9. Click on "Insert Variable..." button;
10. Select any link from the list for example;
11. Click on "Save Template" button;
12. Click on "Preview" link in the template grid

Actual result: We've got fatal error message

[Bartlomiejsz]

@magento-engcom-team give me 2.3-develop instance

[magento-engcom-team]

Hi @Bartlomiejsz. Thank you for your request. I'm working on Magento 2.3-develop instance for you

[magento-engcom-team]

Hi @Bartlomiejsz, here is your Magento instance.
Admin access: https://i-22469-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

[Bartlomiejsz]

@magento-engcom-team give me test instance

[magento-engcom-team]

Hi @Bartlomiejsz. Thank you for your request. I'm working on Magento instance for you

[magento-engcom-team]

Hi @Bartlomiejsz, here is your new Magento instance.
Admin access: https://pr-22469.instances.magento-community.engineering/admin
Login: admin Password: 123123q

[Bartlomiejsz]

@stoleksiy this error is not caused by those changes. You can see exactly same error when you follow those steps on 2.3-develop instance:

1. Login to Admin;
2. Go to Marketing->Communications->Email Templates;
3. Click on "Add New Template" button;
4. Select "New Account" template from the list for example;
5. Click on "Load Template" button;
6. Fill all required fields;
7. Move cursor to the beginning of template (before header path being loaded)
8. Click on "Insert Variable..." button;
9. Select any link from the list for example;
10. Click on "Save Template" button;
11. Click on "Preview" link in the template grid

This is because as result you have incorrect html being saved (variable is injected before <!DOCTYPE and this have nothing to do with changes from PR. This even have nothing to do with injecting variables because customer can write any dummy text before header in template and result will be the same I believe.

[soleksii]

@Bartlomiejsz Thanks for the clarification!

[soleksii]

✔️ QA Passed

Before:

After:

[m2-assistant]

Hi @Bartlomiejsz, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

[roma84]

After this fix, template variables are missing when creating a new template: https://prnt.sc/nxj254
So, this fix reverts the issue.