Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't change customer group when placing an admin order #21144

Closed
gaurav-473 opened this issue Feb 12, 2019 · 14 comments
Closed

Can't change customer group when placing an admin order #21144

gaurav-473 opened this issue Feb 12, 2019 · 14 comments
Labels
Component: Sales Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@gaurav-473
Copy link
Contributor

When ordering in the admin, we can't change the customer group when creating a new customer while creating an order.

Preconditions

  1. Magento 2.3
  2. Several Customer Groups created

Steps to reproduce

  1. In admin select Sales->Orders.
  2. Select Create New Order
  3. Select Create New Customer
  4. Under Account Information, change the group.

Expected result

  1. Selected customer group stays selected in select box.
  2. Product prices are updated for the group.

Actual result

  1. Wait overlay comes up, twice.
  2. Customer group goes back to the default.
  3. Email input box to the right is cleared.
  4. Product prices stay the same.

Note: this issue is similiar to #7974 and #6162

@magento-engcom-team
Copy link
Contributor

Hi @gauravagarwal1001. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@gauravagarwal1001 do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Feb 12, 2019
@shikhamis11 shikhamis11 self-assigned this Feb 12, 2019
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Feb 12, 2019

Hi @shikhamis11. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • Next steps are available in case you are a member of Community Maintainers.

  • 6. Add label Issue: Confirmed once verification is complete.

  • 7. Make sure that automatic system confirms that report has been added to the backlog.

@shikhamis11
Copy link
Member

@magento-engcom-team give me 2.3-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @shikhamis11. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @shikhamis11, here is your Magento instance.
Admin access: https://i-21144-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@shikhamis11 shikhamis11 added Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Component: Sales Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Feb 12, 2019
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @shikhamis11
Thank you for verifying the issue. Based on the provided information internal tickets MAGETWO-98214, MAGETWO-98215 were created

Issue Available: @shikhamis11, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Feb 12, 2019
@magento-engcom-team magento-engcom-team added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Feb 14, 2019
@magento-engcom-team
Copy link
Contributor

Hi @gauravagarwal1001. Thank you for your report.
The issue has been fixed in #21145 by @gauravagarwal1001 in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.2 release.

magento-engcom-team added a commit that referenced this issue Feb 14, 2019
… admin order #21145

 - Merge Pull Request #21145 from gauravagarwal1001/magento2:2.3-develop1Pr
 - Merged commits:
   1. 7646850
@magento-engcom-team magento-engcom-team added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Feb 15, 2019
@magento-engcom-team
Copy link
Contributor

Hi @gauravagarwal1001. Thank you for your report.
The issue has been fixed in #21239 by @amol2jcommerce in 2.2-develop branch
Related commit(s):

The fix will be available with the upcoming 2.2.9 release.

magento-engcom-team added a commit that referenced this issue Feb 15, 2019
… placing an admin order #21239

 - Merge Pull Request #21239 from amol2jcommerce/magento2:2.2-develop-PR-port-21145
 - Merged commits:
   1. d77bc6a
magento-engcom-team pushed a commit that referenced this issue Feb 15, 2019
@kunzi
Copy link

kunzi commented Dec 16, 2019

I'm still having this issue in Magento 2.3.3. Is there a way to fix this?

@wouter-toppy
Copy link

I'm having the same issue still on 2.3.3. can't find a patch

@wouter-toppy
Copy link

@kunzi i found this topic: https://stackoverflow.com/questions/23255545/magento-ce-customer-groups-changing-not-saving

specialy the comment:

I know it is old thread but the issue was in Settings > Customers > Customer Configuration(in your admin panel) . Please set Enable Automatic Assignment to Customer Group to no.

after setting this to 0 the problem is solved ;-)

@web4exposure-org
Copy link

@wouter-toppy
This is not a fix for me, it does make it possible to change the customer group from the backend, but it will also disallow a guest customer to order with a certain (VAT-determined) customer group from the frontend.

I assume an override of the Mage classes will be required to fix both these cases.

@magedev218
Copy link

I am still facing the same issue on Magento version 2.3.3. I have selected YES for Enable Automatic Assignment to Customer Group for Guest Customer with valid VAT ID. Also patch doesnot works for me.

Does any one have solution?

@DominicWatts
Copy link
Contributor

@magedev218 the solution is to set to NO. With the option set to YES Magento is trying to validate the VAT ID - it's failing and reverting the customer group to default. This also affected customer group specific price rules on frontend for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Sales Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

No branches or pull requests

8 participants