Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Fixed #21144 Can't change customer group when placing an admin order #21239

Conversation

amol2jcommerce
Copy link
Contributor

Original Pull Request

#21145
Fixed #21144 Can't change customer group when placing an admin order

When ordering in the admin, we can't change the customer group when creating a new customer while creating an order.

Preconditions

  1. Magento 2.3
  2. Several Customer Groups created

Steps to reproduce

  1. In admin select Sales->Orders.
  2. Select Create New Order
  3. Select Create New Customer
  4. Under Account Information, change the group.

Expected result

  1. Selected customer group stays selected in select box.
  2. Product prices are updated for the group.

Actual result

  1. Wait overlay comes up, twice.
  2. Customer group goes back to the default.
  3. Email input box to the right is cleared.
  4. Product prices stay the same.

Note: this issue is similiar to #7974 and #6162

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @amol2jcommerce. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-4272 has been created to process this Pull Request

@ghost
Copy link

ghost commented Feb 15, 2019

Hi @amol2jcommerce, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Feb 15, 2019
@magento-engcom-team magento-engcom-team added this to the Release: 2.2.9 milestone Feb 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants