Same product quantity not increment when added with guest user.

[krishprakash]

Preconditions (*)

1. Magento 2.2.x
2. Magento 2.3.x

Steps to reproduce (*)

1. Login >>Add product X to the cart from Listing page
2. Logout
3. Add product X to the cart from product detail page as guest user
4. Login using same account.
5. Review the cart

Expected result (*)

Product Qty should be incremented not added separately after login if same product is already added into cart.

Actual result (*)

[magento-engcom-team]

Hi @krishprakash. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@krishprakash do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

• yes
• no

[Jitheesh]

Hi @krishprakash

I can replicate this issue on Magento 2.3 develop instance on following scenario.

1. Login, Add product X to basket from Listing page
2. Logout
3. Add product X to basket from product view page as guest user
4. Login using same account.
5. Review basket, Basket will contains same product as two item

This issue is because of additional buy request parameters while we adding product from product view page.

After customer login Magento will load customer quote and merge this into current quote, while merging quotes, it will compare quote items.

magento2/app/code/Magento/Quote/Model/Quote/Item/Compare.php

Lines 69 to 87 in 310648c

	public function compare(Item $target, Item $compared)
	{
	if ($target->getProductId() != $compared->getProductId()) {
	return false;
	}
	$targetOptions = $this->getOptions($target);
	$comparedOptions = $this->getOptions($compared);
	if (array_diff_key($targetOptions, $comparedOptions) != array_diff_key($comparedOptions, $targetOptions)
	) {
	return false;
	}
	foreach ($targetOptions as $name => $value) {
	if ($comparedOptions[$name] != $value) {
	return false;
	}
	}
	return true;
	}

quoteOptionFromViewPage

array ( 'info_buyRequest' => array ( 'product' => '1', 'item' => '1', ), )

quoteOptionFromListingPage
array ( 'info_buyRequest' => array ( 'product' => '1', ), )

Item comparison failed because of 'item' parameter in the buy request.

magento2/app/code/Magento/Catalog/view/frontend/templates/product/view/form.phtml

Line 25 in 310648c

<input type="hidden" name="item" value="<?= /* @noEscape */ $block->getRequest()->getParam('id') ?>" />

same issue will happen if you add related products along with main product.

[dipti2jcommerce]

@magento-engcom-team give me 2.3-develop instance

[magento-engcom-team]

Hi @dipti2jcommerce. Thank you for your request. I'm working on Magento 2.3-develop instance for you

[magento-engcom-team]

Hi @dipti2jcommerce, here is your Magento instance.
Admin access: https://i-21375-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

[shikhamis11]

@magento-engcom-team give me 2.2-develop instance

[magento-engcom-team]

Hi @shikhamis11. Thank you for your request. I'm working on Magento 2.2-develop instance for you

[magento-engcom-team]

Hi @shikhamis11, here is your Magento instance.
Admin access: https://i-21375-2-2-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

[magento-engcom-team]

Hi @shikhamis11. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.3-develop branch

  Details

  - Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Verify that the issue is reproducible on 2.2-develop branch.

  Details

  - Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

• Next steps are available in case you are a member of Community Maintainers.

• 6. Add label Issue: Confirmed once verification is complete.

• 7. Make sure that automatic system confirms that report has been added to the backlog.

[shikhamis11]

@Jitheesh yes you are right I am able to reproduce the issue with your provided step
@krishprakash it will be better if you update Steps to reproduce (*) as it is not reproducable in all scenarios

[magento-engcom-team]

✅ Confirmed by @shikhamis11
Thank you for verifying the issue. Based on the provided information internal tickets MAGETWO-98355, MAGETWO-98356 were created

Issue Available: @shikhamis11, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

[magento-engcom-team]

Hi @shikhamis11. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

• 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 2. Verify that the issue is reproducible on 2.3-develop branch

  Details

  - Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 3. Verify that the issue is reproducible on 2.2-develop branch.

  Details

  - Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

• 4. If the issue is not relevant or is not reproducible any more, feel free to close it.

[magento-engcom-team]

Hi @Jitheesh. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

• 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 2. Verify that the issue is reproducible on 2.3-develop branch

  Details

  - Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 3. Verify that the issue is reproducible on 2.2-develop branch.

  Details

  - Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

• 4. If the issue is not relevant or is not reproducible any more, feel free to close it.

[magento-engcom-team]

Hi @krishprakash. Thank you for your report.
The issue has been fixed in #21501 by @Jitheesh in 2.3-develop branch
Related commit(s):

• 30dbc79466e6fc383caae2cfa743eb81147e3540

The fix will be available with the upcoming 2.3.2 release.

[magento-engcom-team]

Hi @krishprakash. Thank you for your report.
The issue has been fixed in #22378 by @amol2jcommerce in 2.2-develop branch
Related commit(s):

• 57af527696d73c9488afbb15f9642785ef110819

The fix will be available with the upcoming 2.2.9 release.

[cgsoratto]

I found! The problem is in the 'StripeIntegration_Payments' module. There is an observer for 'checkout_cart_product_add_after' that always changes the "code" to "additional_options".

app/code/StripeIntegration/Payments/Observer/AddInitialFeeObserver.php