Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Same product quantity not increment when added with guest user. #21375 #21501

Merged

Conversation

Jitheesh
Copy link
Contributor

Description (*)

This issue is because of additional buy request parameters while we adding product from product view page.

After customer login Magento will load customer quote and merge this into current quote, while merging quotes, it will compare quote items.

quoteOptionFromViewPage
array ( 'info_buyRequest' => array ( 'product' => '1', 'item' => '1', ), )

quoteOptionFromListingPage
array ( 'info_buyRequest' => array ( 'product' => '1', ), )

Item comparison failed because of 'item' parameter in the buy request. Same issue will happen if we add related products along with main products.

Fixed Issues (if relevant)

  1. Same product quantity not increment when added with guest user. #21375: Same product quantity not increment when added with guest user

Manual testing scenarios (*)

  1. Login, Add product X to basket from Listing page
  2. Logout
  3. Add product X to basket from product view page as guest user
  4. Login using same account.
  5. Review basket, product X qty incremented. It shouldn't be listed as different item
  6. Logout and Repeat steps with related products from product view page

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

…to#21375

- removed non required item options while comparing with merge items
@magento-engcom-team
Copy link
Contributor

Hi @Jitheesh. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@swnsma swnsma self-requested a review April 4, 2019 18:09
@magento-engcom-team
Copy link
Contributor

Hi @swnsma, thank you for the review.
ENGCOM-4669 has been created to process this Pull Request

@soleksii
Copy link

✔️ QA Passed

Before:

before

After:

after

@m2-assistant
Copy link

m2-assistant bot commented Apr 16, 2019

Hi @Jitheesh, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants