Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkout Agreements checkbox missing asterisk #21648

Closed
Karlasa opened this issue Mar 8, 2019 · 5 comments
Closed

Checkout Agreements checkbox missing asterisk #21648

Karlasa opened this issue Mar 8, 2019 · 5 comments
Labels
Component: CheckoutAgreements Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@Karlasa
Copy link
Contributor

Karlasa commented Mar 8, 2019

Preconditions (*)

saw issue in both 2.2 and 2.3

Steps to reproduce (*)

  1. Create Terms and Conditions agreement
  2. Enable it with "manual" setting so checkbox would be shown
  3. Go to checkout

Expected result (*)

Agreement checkbox label should have red asterisk as it's required to check it

Actual result (*)

Asterisk is missing and after pressing place order gives message that field is required

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Mar 8, 2019
@magento-engcom-team
Copy link
Contributor

Hi @Karlasa. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@Karlasa do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@magento-engcom-team
Copy link
Contributor

Hi @engcom-backlog-nazar. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • Next steps are available in case you are a member of Community Maintainers.

  • 6. Add label Issue: Confirmed once verification is complete.

  • 7. Make sure that automatic system confirms that report has been added to the backlog.

@ghost ghost added Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Component: CheckoutAgreements labels Mar 11, 2019
@rogyar rogyar added Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Mar 12, 2019
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @rogyar
Thank you for verifying the issue. Based on the provided information internal tickets MAGETWO-98658 were created

Issue Available: @rogyar, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Mar 12, 2019
@ghost ghost removed their assignment Mar 12, 2019
@magento-engcom-team
Copy link
Contributor

Hi @Karlasa. Thank you for your report.
The issue has been fixed in #21649 by @Karlasa in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.2 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Mar 18, 2019
magento-engcom-team added a commit that referenced this issue Mar 18, 2019
…21649

 - Merge Pull Request #21649 from Karlasa/magento2:fix-checkout-asterisk
 - Merged commits:
   1. e6167ad
   2. afa0320
   3. 92d93f5
   4. 46bbdd0
   5. a39e221
@magento-engcom-team magento-engcom-team added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Mar 20, 2019
@magento-engcom-team
Copy link
Contributor

Hi @Karlasa. Thank you for your report.
The issue has been fixed in #21838 by @amol2jcommerce in 2.2-develop branch
Related commit(s):

The fix will be available with the upcoming 2.2.9 release.

magento-engcom-team added a commit that referenced this issue Mar 20, 2019
…ng asterisk #21838

 - Merge Pull Request #21838 from amol2jcommerce/magento2:2.2-develop-PR-port-21649
 - Merged commits:
   1. 079ecb3
   2. 943fb33
   3. 745df9a
   4. 8c609c4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: CheckoutAgreements Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

No branches or pull requests

3 participants