Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Fix #21648 Checkout Agreements checkbox missing asterisk #21838

Conversation

amol2jcommerce
Copy link
Contributor

Original Pull Request

#21649

Description (*)

Fixed Issues (if relevant)

  1. Checkout Agreements checkbox missing asterisk #21648 : missing asterisk in checkout Agreements

Manual testing scenarios (*)

Create Terms and Conditions agreement
Enable it with "manual" setting so checkbox would be shown
Go to checkout
Expected result (*)
Agreement checkbox label should have red asterisk as it's required to check it

Actual result (*)
Asterisk is missing and after pressing place order gives message that field is required

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Karlasa added 4 commits March 19, 2019 15:12
not needed with correct html classes
added correct class for asterisk
@magento-engcom-team
Copy link
Contributor

Hi @amol2jcommerce. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Contributor

Hi @Karlasa, thank you for the review.
ENGCOM-4535 has been created to process this Pull Request

@soleksii
Copy link

✔️ QA Passed

Result (Luma):

after(luma)

Result (Blank):

after(blank)

@ghost
Copy link

ghost commented Mar 20, 2019

Hi @amol2jcommerce, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants