Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes for PayPal affect core config fields with tooltip #21974

Closed
AndreasMueller75 opened this issue Mar 27, 2019 · 7 comments
Closed

Changes for PayPal affect core config fields with tooltip #21974

AndreasMueller75 opened this issue Mar 27, 2019 · 7 comments
Assignees
Labels
Component: Backend Event: dmcdindia1 Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line good first issue Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@AndreasMueller75
Copy link

AndreasMueller75 commented Mar 27, 2019

Preconditions (*)

  1. Magento 2.3.1
  2. PHP 7.*

Steps to reproduce (*)

  1. create an config field, type time with a tooltip in a group in a section (see below)
<?xml version="1.0" ?>
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:module:Magento_Config:etc/system_file.xsd">
    <system>
        <section id="shipping" showInDefault="1" showInStore="1" showInWebsite="1" translate="label tooltip comment">
            <group id="test_group" showInDefault="1" showInStore="1" showInWebsite="1" sortOrder="0" translate="label tooltip comment">
                <field id="test_time" showInDefault="1" showInWebsite="1" showInStore="0" sortOrder="10"
                       translate="label tooltip comment" type="time">
                   <label><![CDATA[Test Time]]></label>
                   <source_model>Magento\Config\Model\Config\Source\Date\Short</source_model>
                   <tooltip><![CDATA[Testtooltip.]]></tooltip>
                </field>
            </group>
        </section>
    </system>
</config>

Expected result (*)

The time fields are separated by colons (:)
expected

Actual result (*)

The colons are missing (have a font-size of 0).
actual

The reason

The change in vendor/magento/theme-adminhtml-backend/Magento_Backend/web/css/source/module/main/_collapsible-blocks.less from the following commit sets the font-size of all input-field labels with a tooltip to 0.

 .value {
            padding-right: 40px;
            vertical-align: middle;
            width: 44%;

            &.with-tooltip {
                font-size: 0;

Proposed Resolution

The css selector (.accordion .config .value.with-tooltip) is too general and should be more precise for setting font-size: 0 in PayPals usecase.

@magento-engcom-team
Copy link
Contributor

Hi @AndreasMueller75. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@AndreasMueller75 do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Mar 27, 2019
@AndreasMueller75 AndreasMueller75 changed the title Changes for PayPal affects display core config field with tooltip in general Changes for PayPal affect core config fields with tooltip Mar 28, 2019
@AndreasMueller75
Copy link
Author

Hi, i reworked the issue description. The issue is easily reproducible in Magento 2.3.1.

@ghost ghost self-assigned this Mar 29, 2019
@ghost ghost added Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Component: Backend Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Fixed in 2.2.x The issue has been fixed in 2.2 release line Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Mar 29, 2019
@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Mar 29, 2019
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @engcom-backlog-nazar
Thank you for verifying the issue. Based on the provided information internal tickets MAGETWO-98971 were created

Issue Available: @engcom-backlog-nazar, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@geet07
Copy link

geet07 commented May 4, 2019

I am working on this at #dmcdindia19”

@magento-engcom-team
Copy link
Contributor

@geet07 thank you for joining. Please accept team invitation here and self-assign the issue.

@m2-assistant
Copy link

m2-assistant bot commented May 4, 2019

Hi @geet07. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

  • 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 2. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 3. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 4. If the issue is not relevant or is not reproducible any more, feel free to close it.

@geet07 geet07 mentioned this issue Jun 25, 2019
4 tasks
@magento-engcom-team
Copy link
Contributor

Hi @AndreasMueller75. Thank you for your report.
The issue has been fixed in #23393 by @geet07 in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.3 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Jun 27, 2019
magento-engcom-team added a commit that referenced this issue Jun 27, 2019
 - Merge Pull Request #23393 from geeta07/magento2:fix-21974
 - Merged commits:
   1. eb28f14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Backend Event: dmcdindia1 Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line good first issue Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

No branches or pull requests

4 participants