Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changes for paypal_affect_core_config_fields_with_tooltip #22035

Conversation

amol2jcommerce
Copy link
Contributor

Description (*)

#21974: Changes for PayPal affect core config fields with tooltip

Fixed Issues (if relevant)

  1. Magento 2.3.x

Manual testing scenarios (*)

  1. create an config field, type time with a tooltip in a group in a section (Changes for PayPal affect core config fields with tooltip  #21974)

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Copy link
Contributor

@VladimirZaets VladimirZaets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @amol2jcommerce. Thanks for collaboration. Are you investigate the reason why font-size was set to 0, font-size: 0 very specific setting, so I think we had some reason to do it

@amol2jcommerce
Copy link
Contributor Author

Hi @VladimirZaets I checked but no idea about font-size: 0, I cross check with 2.2 instance but not found font-size and issue not generated. It's occurs only 2.3, fixed in 2.2

@VladimirZaets
Copy link
Contributor

Hi @amol2jcommerce. The style font-size: 0 was added because of not input fields (select as an example) in the system configuration wasn't aligned by the center of the page.
Please check that case and fix it in a compatible way

@VladimirZaets
Copy link
Contributor

@amol2jcommerce, I am closing this PR now due to inactivity.
Please reopen and update if you wish to continue.
Thank you for collaboration

@m2-assistant
Copy link

m2-assistant bot commented Apr 26, 2019

Hi @amol2jcommerce, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@geet07 geet07 mentioned this pull request Jun 25, 2019
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants