Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A PHPDoc comment for \Magento\Config\Model\Config\SourceFactory::create() method is wrong #2370

Closed
dmitrii-fediuk opened this issue Nov 14, 2015 · 3 comments
Closed

A PHPDoc comment for \Magento\Config\Model\Config\SourceFactory::create() method is wrong #2370

dmitrii-fediuk opened this issue Nov 14, 2015 · 3 comments
Assignees
@cavalier79 @madotto
Labels
bug report Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development

Comments

@dmitrii-fediuk
Copy link

magento2/app/code/Magento/Config/Model/Config/SourceFactory.php

Line 26 in 2335247

* Create backend model by name

Should be «Create source model by name».

The PHPDoc declaration for result can be improved too:

magento2/app/code/Magento/Config/Model/Config/SourceFactory.php

Line 29 in 2335247

* @return mixed

@return \Magento\Framework\Option\ArrayInterface|object
would be better.
@NadiyaS NadiyaS added the PS label Nov 16, 2015
@joanhe
Copy link
Contributor

joanhe commented Nov 16, 2015

@dfediuk Thank you for reporting this issue. Internal issue MAGETWO-45625 is created for this.

@joanhe joanhe added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Nov 16, 2015
@vkorotun vkorotun removed the PS label Aug 4, 2016
@okorshenko
Copy link
Contributor

@madotto

madotto added a commit to madotto/magento2 that referenced this issue Mar 2, 2017
@madotto
magento#2370: A PHPDoc comment for \Magento\Config\Model\Config\Sourc…
03051a8 
…eFactory::create() method is wrong\n - Fix typo
magento-team pushed a commit that referenced this issue Mar 8, 2017
MAGETWO-65427: [GitHub][PR] magento/magento2 #2370: A PHPDoc comment …
20c7cdb 
…typo fix #8758

 - Merge Pull Request #8758 from cavalier79/magento2:mcd17
magento-team added a commit that referenced this issue Mar 8, 2017
@magento-team
MAGETWO-65427: [GitHub][PR] magento/magento2 #2370: A PHPDoc comment …
20d4c8c 
…typo fix #8758
@okorshenko
Copy link
Contributor

@dmitry-fedyuk thank you for reporting the issue.
@cavalier79 thank you for fixing this issue in PR: #8758

magento-team pushed a commit that referenced this issue Apr 12, 2018
@dvoskoboinikov
Merge pull request #2370 from magento-qwerty/2.2-bugfixes-060418
4518560 
Fixed issues:
- MAGETWO-87115: Can't create customer account on checkout success page when gender field is required
- MAGETWO-88265: [Performance] Customer Import check data does not complete
@nmalevanec nmalevanec mentioned this issue Jul 2, 2019
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cavalier79 cavalier79

@madotto madotto

Labels
bug report Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@dmitrii-fediuk @cavalier79 @okorshenko @vkorotun @rgoncharuk @joanhe @NadiyaS @madotto