Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

magento/magento2 #2370: A PHPDoc comment typo fix #8758

Closed
wants to merge 2 commits into from
Closed

magento/magento2 #2370: A PHPDoc comment typo fix #8758

wants to merge 2 commits into from

Conversation

cavalier79
Copy link

@cavalier79 cavalier79 commented Mar 2, 2017

Fixed typo in
app/code/Magento/Config/Model/Config/SourceFactory.php on line 26

wrong typo was

@return mixed

fixed in

@return \Magento\Framework\Option\ArrayInterface|object

…nfig\SourceFactory::create() method is wrong

Fixed type in return comment
@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Mar 2, 2017

CLA assistant check
All committers have signed the CLA.

A PHPDoc comment for \Magento\Config\Model\Config\SourceFactory::create() method is wrong
The correct return parameter is  \Magento\Framework\Option\ArrayInterface
@ishakhsuvarov ishakhsuvarov added this to the March 2017 milestone Mar 2, 2017
@ishakhsuvarov ishakhsuvarov self-assigned this Mar 2, 2017
@okorshenko okorshenko self-assigned this Mar 2, 2017
@okorshenko okorshenko self-requested a review March 2, 2017 16:20
@ishakhsuvarov
Copy link
Contributor

@cavalier79 Initial commits were merged to the develop branch. Thank you for contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants