Terms and Conditions label doesn't fit longer texts

[DanieliMi]

Preconditions (*)

1. Version: 2.2.9 | 2.3.2 | 2.4-develop
2. Luma Theme

Summary

When creating Terms and Conditions with a longer checkbox text the label and required asterisk will break into new lines. I think this is not expected behavior and looks odd.

Steps to reproduce (*)

1. Create new Condition with
   1.1. Condition Name: Any
   1.2. Status: Enabled
   1.3. Show Content As: Text
   1.4. Applied: Manually
   1.5. Checkbox Text: A text (>= 114 chars)
   1.6. Content: Any
2. Stores > Configuration > Sales > Checkout > Checkout Options > Enable Terms and Conditions: Yes
3. Flush Magento Cache
4. Go to Checkout
5. Proceed to Billing Step

Expected result (*)

I expect the Terms and Conditions checkbox to appear and being displayed nice.

Actual result (*)

The text is too long and due to that the label is breaking into a new line. Same with the required asterisk.

[m2-assistant]

Hi @DanieliMi. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@DanieliMi do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

• yes
• no

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

[m2-assistant]

Hi @engcom-Bravo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.3-develop branch

  Details

  - Add the comment @magento give me 2.3-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Add label Issue: Confirmed once verification is complete.

• 6. Make sure that automatic system confirms that report has been added to the backlog.

[DanieliMi]

@magento give me 2.3-develop instance

[magento-engcom-team]

Hi @DanieliMi. Thank you for your request. I'm working on Magento 2.3-develop instance for you

[magento-engcom-team]

Hi @DanieliMi, here is your Magento instance.
Admin access: https://i-24060-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

[DanieliMi]

@DanieliMi do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

I can verify the issue on the vanilla instance.

[tprocter-ldg]

You could try adding the following style to the checkout agreement button:

.checkout-agreements-block .action-show { display: contents; }

[amenk]

@tprocter-ldg Awesome idea, but unfortunately not IE11 compatible. https://caniuse.com/#search=display%20contents

[magento-engcom-team]

✅ Confirmed by @engcom-Bravo
Thank you for verifying the issue. Based on the provided information internal tickets MC-19030 were created

Issue Available: @engcom-Bravo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

[DanieliMi]

Another solution would be:

.checkout-agreements-block {
        .checkout-agreements {
            margin-bottom: @indent__base;

            &.fieldset {
                > .field.choice{
                    input[type="checkbox"] {
                        vertical-align: top;
                    }

                    label.label {
                        display: inline-block;
                        max-width: 90%;
                    }
                }
            }
        }

        .action-show {
            &:extend(.abs-action-button-as-link all);
            vertical-align: baseline;
            max-width: 90%
        }
    }
}

But this is really not a nice and clean solution just setting the max-width to 90%.

You could try adding the following style to the checkout agreement button:

.checkout-agreements-block .action-show { display: contents; }

Is a really nice solution if there wouldn't be the lack of supported browsers.

We tried it with display: table and display: table-cell but for this we either have to adapt the markup or move the after for the * to the .checkout-agreement.required which is not a nice solution after all either.

[amenk]

@magento-engcom-team Can the internal ticket status of MC-19030 be viewed in any way? Is there an estimate for the fix?

[m2-assistant]

Hi @edenduong. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

• 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 2. Verify that the issue is reproducible on 2.3-develop branch

  Details

  - Add the comment @magento give me 2.3-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 3. If the issue is not relevant or is not reproducible any more, feel free to close it.

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

[dynamicswebkul]

@magento i am working on it.

[m2-assistant]

Hi @webkul-ramakant. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

• 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 2. Verify that the issue is reproducible on 2.3-develop branch

  Details

  - Add the comment @magento give me 2.3-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 3. If the issue is not relevant or is not reproducible any more, feel free to close it.

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

[magento-engcom-team]

✅ Confirmed by @engcom-Alfa
Thank you for verifying the issue. Based on the provided information internal tickets MC-36819 were created

Issue Available: @engcom-Alfa, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

[magento-engcom-team]

Hi @DanieliMi. Thank you for your report.
The issue has been fixed in #29413 by @Bartlomiejsz in 2.4-develop branch
Related commit(s):

• 5a0680cd19ec70d110ba995996f6f2785258cfb9

The fix will be available with the upcoming 2.4.1 release.