-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #24060 - Terms and Conditions label doesn't fit longer texts #29413
Fix #24060 - Terms and Conditions label doesn't fit longer texts #29413
Conversation
Hi @Bartlomiejsz. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review. For more details, please, review the Magento Contributor Guide documentation. 🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket. 🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
@magento run all tests |
Hi @VladimirZaets, thank you for the review.
|
✔️ QA Passed Manual testing scenario:
Before: ✖️ The text is too long and due to that the label is breaking into a new line. Same with the required asterisk. After: ✔️ Terms and Conditions checkbox appear and being displayed nicely. ✔️ Was checked and on the Blank theme. and on the mobiles and tablets |
Hi @Bartlomiejsz, thank you for your contribution! |
Description (*)
Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
Please check fixed issue for testing steps
Questions or comments
Contribution checklist (*)