Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DependencyTest does not analyze GraphQL schema files #28579

Closed
magento-engcom-team opened this issue Jun 5, 2020 · 3 comments · Fixed by #28747
Closed

DependencyTest does not analyze GraphQL schema files #28579

magento-engcom-team opened this issue Jun 5, 2020 · 3 comments · Fixed by #28747
Assignees
@sasha19957099
Labels
Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed PAP Partners acceleration program Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Project: GraphQL Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Milestone
2.4.1

Comments

@magento-engcom-team
Copy link
Contributor

Steps to reproduce:

  • Add new GraphQl module which will extend existing schema
  • Add dependencies to the module.xml
  • Only schema refers to dependencies

(/) Test is green
(-) Test fails with Redundant dependencies found!
@magento-engcom-team magento-engcom-team added Progress: ready for dev Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch labels Jun 5, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jun 5, 2020

Hi @magento-engcom-team. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this

@nrkapoor nrkapoor added this to the 2.4.1 milestone Jun 5, 2020
@magento-engcom-team magento-engcom-team added the Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed label Jun 5, 2020
@sasha19957099
Copy link
Contributor

@magento I am working on this

@cpartica
Copy link
Contributor

cpartica commented Jun 11, 2020 •
edited
Loading

Soft dependencies:

  • a module that contain a *.graphqls file SHOULDN't be dependent on Graphql module
  • a *.graphqls file that extends (redeclares) an existing type declared in another module SHOULDN't be dependent on the Graphql module that declared the same type

Hard dependencies:

  • a *.graphqls file that implements an existing interface declared in another module SHOULD be dependent on the Graphql module that declared the same type

sasha19957099 added a commit to sasha19957099/magento2 that referenced this issue Jun 16, 2020
@sasha19957099
magento#28579:DependencyTest does not analyze GraphQL schema files - …
64b806f 
…added tests and missing dependency for SwatchesGraphQl module
sasha19957099 added a commit to sasha19957099/magento2 that referenced this issue Jun 17, 2020
@sasha19957099
magento#28579:DependencyTest does not analyze GraphQL schema files - …
5b65095 
…fixed tests
@sasha19957099 sasha19957099 linked a pull request Jun 17, 2020 that will close this issue
magento/magento2#28579:DependencyTest does not analyze GraphQL schema… #28747
Merged
4 tasks
sasha19957099 added a commit to sasha19957099/magento2 that referenced this issue Jun 17, 2020
@sasha19957099
magento#28579:DependencyTest does not analyze GraphQL schema files - …
ce1464e 
…fixed static and integration tests
sasha19957099 added a commit to sasha19957099/magento2 that referenced this issue Jun 18, 2020
@sasha19957099
magento#28579:DependencyTest does not analyze GraphQL schema files - …
6f62bea 
…fixed static code style test
sasha19957099 added a commit to sasha19957099/magento2 that referenced this issue Jun 18, 2020
@sasha19957099
magento#28579:DependencyTest does not analyze GraphQL schema files - …
50639da 
…composer.lock changes
@magento-engcom-team magento-engcom-team added the Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. label Jun 20, 2020
sasha19957099 added a commit to sasha19957099/magento2 that referenced this issue Jun 22, 2020
@sasha19957099
magento#28579:DependencyTest does not analyze GraphQL schema files - …
b6ae25b 
…fixed static test
sasha19957099 added a commit to sasha19957099/magento2 that referenced this issue Jun 23, 2020
@sasha19957099
magento#28579:DependencyTest does not analyze GraphQL schema files - …
e76f1c5 
…added requested changes
@cpartica cpartica added the PAP Partners acceleration program label Jun 25, 2020
sasha19957099 added a commit to sasha19957099/magento2 that referenced this issue Jun 26, 2020
@sasha19957099
magento#28579:DependencyTest does not analyze GraphQL schema files - …
d64ef3d 
…fixed reaquested changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sasha19957099 sasha19957099

Labels
Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed PAP Partners acceleration program Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Project: GraphQL Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
None yet
Milestone
2.4.1
Development

Successfully merging a pull request may close this issue.

magento/magento2#28579:DependencyTest does not analyze GraphQL schema… sasha19957099/magento2
4 participants
@nrkapoor @cpartica @sasha19957099 @magento-engcom-team