magento/magento2#28579:DependencyTest does not analyze GraphQL schema… #28747

sasha19957099 · 2020-06-16T19:05:42Z

… files - added tests and missing dependency for SwatchesGraphQl module

Description (*)

Related Pull Requests

https://github.com/magento/partners-magento2-infrastructure/pull/8

Fixed Issues (if relevant)

Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

...
...

Questions or comments

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds are green)

…added tests and missing dependency for SwatchesGraphQl module

m2-assistant · 2020-06-16T19:05:45Z

Hi @sasha19957099. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

…_GraphQL_schema_files

sasha19957099 · 2020-06-16T19:07:21Z

@magento run all tests

…fixed tests

sasha19957099 · 2020-06-17T12:01:39Z

@magento run all tests

…_GraphQL_schema_files

ghost · 2020-06-17T22:02:10Z

@sasha19957099 unfortunately, only members of the maintainers team are allowed to assign developers to the pull request

…fixed static and integration tests

sasha19957099 · 2020-06-17T22:25:21Z

@magento run all tests

…fixed static code style test

…composer.lock changes

sasha19957099 · 2020-06-18T08:02:39Z

@magento run Magento Health Index
@magento run Static Tests

sasha19957099 · 2020-06-18T09:07:50Z

@magento run Static Tests

sasha19957099 · 2020-06-18T12:05:23Z

Here is a problem. Running static tests on the Magento build we don't have Magento app instance. It is a cause of failing static tests https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/28747/3fbd463f86fe3e705dc9d439abe63716/Statics/allure-report-ee/index.html#categories/f8421ffb12c0de5091bdf17e30c0fef2/1774e386c6824151/
So interface Magento\Framework\GraphQlSchemaStitching\GraphQlReader\TypeMetaReaderInterface can't be instantiated. How we can solve it?

sasha19957099 · 2020-06-18T12:22:18Z

@magento run all tests

…ependencies() fix

sasha19957099 · 2020-06-24T14:59:46Z

@magento run all tests

cpartica · 2020-06-24T18:49:51Z

dev/tests/static/testsuite/Magento/Test/Integrity/Dependency/DependencyProvider.php

+     */
+    public function __construct()
+    {
+        $this->initDeclaredDependencies();


this would make this class instantiate very slowly unless you use a Proxy class.
the other solution would be to call init before calling addDependencies or getDeclaredDependencies. basically any public method of this class

yes, you're right, changed to the proxy.

what I meant that instead of using a proxy ..better call that initDeclaredDependencies within addDependencies and getDeclaredDependencies and remove it from constructor.
It's even better than a proxy.

to avoid using an init in the constructor you can move it into the method where it is needed.
e.g.

function getDependencies(){ if(empty($dependencies)){ doInit(); } return $this->dependencies; }

sasha19957099 · 2020-06-25T11:14:39Z

@magento run all tests

cpartica · 2020-06-25T20:37:59Z

dev/tests/static/testsuite/Magento/Test/Integrity/Dependency/DependencyProvider.php

+    /**
+     * Types of dependency between modules.
+     */
+    const TYPE_HARD = 'hard';


looks like we have a new requirement to add "public" to const @see https://github.com/magento/magento2/pull/28713/files#diff-16beb87a670284151b84072a3fc8cc4dR17

cpartica · 2020-06-25T20:39:39Z

dev/tests/static/testsuite/Magento/Test/Integrity/Dependency/DependencyProvider.php

+    /**
+     * DependencyProvider constructor.
+     * @throws \Magento\Framework\Exception\LocalizedException
+     * @throws \Magento\TestFramework\Inspection\Exception


try to add all namespaces and move the to a "use" statement

cpartica · 2020-06-25T20:40:20Z

...s/static/testsuite/Magento/Test/Integrity/Dependency/DeclarativeSchemaDependencyProvider.php


    /**
-     * @var array
+     * DeclarativeSchemaDependencyProvider constructor.


you don't need a comment description in constructors

cpartica · 2020-06-25T20:42:45Z

...tests/static/testsuite/Magento/Test/Integrity/Dependency/GraphQlSchemaDependencyProvider.php

+    public function __construct(\Magento\Test\Integrity\Dependency\DependencyProvider\Proxy $dependencyProvider)
+    {
+        $this->dependencyProvider = $dependencyProvider;
+        $this->getGraphQlSchemaDeclaration();


this will again do constructor processing delaying instantiation of the class

cpartica · 2020-06-25T20:47:14Z

dev/tests/static/testsuite/Magento/Test/Integrity/Dependency/DependencyProvider.php

+     */
+    public function __construct()
+    {
+        $this->initDeclaredDependencies();


what I meant that instead of using a proxy ..better call that initDeclaredDependencies within addDependencies and getDeclaredDependencies and remove it from constructor.
It's even better than a proxy.

cpartica · 2020-06-25T20:47:40Z

...tests/static/testsuite/Magento/Test/Integrity/Dependency/GraphQlSchemaDependencyProvider.php

+                $interfaces = array_keys($type['implements']);
+                foreach ($interfaces as $interface) {
+                    $dependOnModule = $schema[$interface]['module'];
+                    if ($dependOnModule != $moduleName) {


cpartica · 2020-06-25T20:48:07Z

...tests/static/testsuite/Magento/Test/Integrity/Dependency/GraphQlSchemaDependencyProvider.php

+        $dependencies = [];
+
+        foreach ($schema as $type) {
+            if (isset($type['module']) && $type['module'] == $moduleName && isset($type['implements'])) {


cpartica · 2020-06-25T20:50:21Z

lib/internal/Magento/Framework/GraphQlSchemaStitching/GraphQlReader.php

+                break;
+            }
+        }
+        if (empty($foundModuleName)) {


isn't $foundModuleName = ''; already empty if not set by foreach?

…fixed reaquested changes

sasha19957099 · 2020-06-26T11:11:05Z

@magento run Static Tests

sasha19957099 · 2020-06-26T11:15:07Z

@magento run Static Tests

sasha19957099 · 2020-06-26T12:00:09Z

@magento run Static Tests

sasha19957099 · 2020-06-26T12:46:57Z

@magento run all tests

cpartica · 2020-06-26T21:38:23Z

dev/tests/static/testsuite/Magento/Test/Integrity/DeclarativeDependencyTest.php

     */
    private function readJsonFile(string $file, bool $asArray = false)
    {
        $decodedJson = json_decode(file_get_contents($file), $asArray);
        if (null == $decodedJson) {
-            //phpcs:ignore Magento2.Exceptions.DirectThrow
-            throw new \Exception("Invalid Json: $file");
+            throw new InspectionException("Invalid Json: $file");


missed this, we usually do a localized exception that's translatable and any parameters like file go into a "%1" or "%s" if using sprintf.
This is probably fine because it's a test. But "Invalid Json: $file" would still be a risky practice and sprintf would be preferred.

…28747

m2-assistant · 2020-07-15T16:45:15Z

Hi @sasha19957099, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento#28579:DependencyTest does not analyze GraphQL schema files - …

64b806f

…added tests and missing dependency for SwatchesGraphQl module

ghost added the Progress: pending review label Jun 16, 2020

magento-engcom-team added Component: SwatchesGraphQl Component: GraphQlSchemaStitching Release Line: 2.4 labels Jun 16, 2020

Merge branch '2.4-develop' into 28579_DependencyTest_does_not_analyze…

e19d807

…_GraphQL_schema_files

magento#28579:DependencyTest does not analyze GraphQL schema files - …

5b65095

…fixed tests

sasha19957099 linked an issue Jun 17, 2020 that may be closed by this pull request

DependencyTest does not analyze GraphQL schema files #28579

Closed

Merge branch '2.4-develop' into 28579_DependencyTest_does_not_analyze…

a7037ce

…_GraphQL_schema_files

sasha19957099 self-assigned this Jun 17, 2020

ghost unassigned sasha19957099 Jun 17, 2020

magento#28579:DependencyTest does not analyze GraphQL schema files - …

ce1464e

…fixed static and integration tests

sasha19957099 added 2 commits June 18, 2020 10:13

magento#28579:DependencyTest does not analyze GraphQL schema files - …

6f62bea

…fixed static code style test

magento#28579:DependencyTest does not analyze GraphQL schema files - …

50639da

…composer.lock changes

sasha19957099 added the Project: GraphQL label Jun 18, 2020

nrkapoor requested review from dthampy and cpartica and removed request for dthampy June 20, 2020 13:23

nrkapoor assigned sasha19957099 Jun 20, 2020

nrkapoor added this to the 2.4.1 milestone Jun 20, 2020

magento#27952: missing store_name in GraphQL resolver - initDeclaredD…

0e32b44

…ependencies() fix

sasha19957099 requested a review from cpartica June 24, 2020 15:00

cpartica requested changes Jun 24, 2020

View reviewed changes

cpartica added the PAP Partners acceleration program label Jun 25, 2020

magento#27952: missing store_name in GraphQL resolver - changed to proxy

8c4cff4

cpartica requested changes Jun 25, 2020

View reviewed changes

ghost assigned danielrenaud Jun 25, 2020

magento#28579:DependencyTest does not analyze GraphQL schema files - …

d64ef3d

…fixed reaquested changes

Delete 3a0f0075-1d21-444e-881d-40cea007b24f-testsuite.xml

1305a3e

cpartica approved these changes Jun 26, 2020

View reviewed changes

ghost added Progress: ready for testing and removed Progress: needs update labels Jun 26, 2020

ghost added Progress: testing in progress and removed Progress: ready for testing labels Jun 26, 2020

ghost added Progress: accept and removed Progress: testing in progress labels Jul 7, 2020

magento-engcom-team pushed a commit that referenced this pull request Jul 15, 2020

ENGCOM-7795: #28579:DependencyTest does not analyze GraphQL schema… #…

80c731b

…28747

magento-engcom-team merged commit f82ed7d into magento:2.4-develop Jul 15, 2020

convenient mentioned this pull request Jan 28, 2021

Fix performance when parsing GraphQL schema into AST which causes downtime on cache stampede #31879

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

magento/magento2#28579:DependencyTest does not analyze GraphQL schema… #28747

magento/magento2#28579:DependencyTest does not analyze GraphQL schema… #28747

sasha19957099 commented Jun 16, 2020 •

edited by cpartica

Loading

m2-assistant bot commented Jun 16, 2020

sasha19957099 commented Jun 16, 2020

sasha19957099 commented Jun 17, 2020

ghost commented Jun 17, 2020

sasha19957099 commented Jun 17, 2020

sasha19957099 commented Jun 18, 2020

sasha19957099 commented Jun 18, 2020

sasha19957099 commented Jun 18, 2020

sasha19957099 commented Jun 18, 2020

sasha19957099 commented Jun 24, 2020

cpartica Jun 24, 2020

sasha19957099 Jun 25, 2020

cpartica Jun 25, 2020

danielrenaud Jun 25, 2020

sasha19957099 commented Jun 25, 2020

cpartica Jun 25, 2020

cpartica Jun 25, 2020

cpartica Jun 25, 2020

cpartica Jun 25, 2020

cpartica Jun 25, 2020

cpartica Jun 25, 2020

cpartica Jun 25, 2020

cpartica Jun 25, 2020

sasha19957099 commented Jun 26, 2020

sasha19957099 commented Jun 26, 2020

sasha19957099 commented Jun 26, 2020

sasha19957099 commented Jun 26, 2020

cpartica Jun 26, 2020

m2-assistant bot commented Jul 15, 2020

magento/magento2#28579:DependencyTest does not analyze GraphQL schema… #28747

magento/magento2#28579:DependencyTest does not analyze GraphQL schema… #28747

Conversation

sasha19957099 commented Jun 16, 2020 • edited by cpartica Loading

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

m2-assistant bot commented Jun 16, 2020

sasha19957099 commented Jun 16, 2020

sasha19957099 commented Jun 17, 2020

ghost commented Jun 17, 2020

sasha19957099 commented Jun 17, 2020

sasha19957099 commented Jun 18, 2020

sasha19957099 commented Jun 18, 2020

sasha19957099 commented Jun 18, 2020

sasha19957099 commented Jun 18, 2020

sasha19957099 commented Jun 24, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sasha19957099 commented Jun 25, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sasha19957099 commented Jun 26, 2020

sasha19957099 commented Jun 26, 2020

sasha19957099 commented Jun 26, 2020

sasha19957099 commented Jun 26, 2020

Choose a reason for hiding this comment

m2-assistant bot commented Jul 15, 2020

sasha19957099 commented Jun 16, 2020 •

edited by cpartica

Loading