Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

“Product Reviews” can not be sorted by Admin on the Product page #30270

Closed
magento-engcom-team opened this issue Sep 30, 2020 · 9 comments · Fixed by #30477
Closed

“Product Reviews” can not be sorted by Admin on the Product page #30270

magento-engcom-team opened this issue Sep 30, 2020 · 9 comments · Fixed by #30477
Assignees
@Chandresh22
Labels
CD Issue recommended for the contribution day Component: Other Event: dmcdindia2020 Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Reported on 2.3.5-p2 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.

Comments

@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Sep 30, 2020 •
edited
Loading

Preconditions:

  • Magento EE 2.3.5-p2, EE 2.4.0, EE 2.4.1, EE 2.4.2-alpha1 is installed, should be actual for CE
  • A Simple Product is created

Steps to Reproduce:

  • Go to the Storefront as a guest
  • Go to the created Product page
  • Add at least 2 reviews
  • Go to Magento Admin > Marketing > Pending Reviews
  • Approve the added reviews
  • Go to Magento Admin > Ctalog > Products
  • Select the created Product
  • Click the “Edit” link
  • Open the “Product Reviews” section
  • Sort “Product Reviews” for example, by ID, clicking the “ID” cell

(/) Expected results:

All records of “Product Reviews” grid should be sorted by selected parameter

(x) Actual results:

Records of “Product Reviews” grid are not sorted

 
@magento-engcom-team magento-engcom-team added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: ready for dev Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Sep 30, 2020
@magento-engcom-team
Copy link
Contributor Author

The issue was exported from the internal JIRA. The link to the original JIRA issue: https://jira.corp.magento.com/browse/MC-36265

@m2-assistant
Copy link

m2-assistant bot commented Sep 30, 2020

Hi @magento-engcom-team. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this

⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@magento-engcom-team magento-engcom-team added Component: Other Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch labels Sep 30, 2020
@magento-engcom-team
Copy link
Contributor Author

✅ Confirmed by @magento-engcom-team
Thank you for verifying the issue. Based on the provided information internal tickets MC-36265 were created

Issue Available: @magento-engcom-team, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Sep 30, 2020
@sivaschenko sivaschenko added the CD Issue recommended for the contribution day label Oct 7, 2020
@Chandresh22
Copy link
Contributor

@magento add to contributors team

@m2-assistant
Copy link

m2-assistant bot commented Oct 9, 2020

Hi @Chandresh22! 👋
Thank you for joining. Please accept team invitation 👉 here 👈 and add your comment one more time.

@Chandresh22
Copy link
Contributor

@magento I am working on it

@Sweetyagarwal
Copy link

@magento I am working on it.

@Sweetyagarwal
Copy link

#dmcdindia2020

This was referenced Oct 12, 2020
Closed
Merged
@ghost ghost unassigned Sweetyagarwal Nov 4, 2020
@magento-engcom-team magento-engcom-team added the Reported on 2.3.5-p2 Indicates original Magento version for the Issue report. label Nov 13, 2020
@magento-engcom-team
Copy link
Contributor Author

Hi @magento-engcom-team. Thank you for your report.
The issue has been fixed in #30477 by @Chandresh22 in 2.4-develop branch
Related commit(s):

The fix will be available with the upcoming 2.4.3 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.4.x The issue has been fixed in 2.4-develop branch label Dec 10, 2020
magento-engcom-team added a commit that referenced this issue Dec 10, 2020
@magento-engcom-team
ENGCOM-8501: Fix issue #30270 Product Reviews can not be sorted by Ad…
0b893ee 
…min on the Product edit page #30477

 - Merge Pull Request #30477 from Chandresh22/magento2:2.4-develop
 - Merged commits:
   1. 4c5a130
   2. 4e80ef9
   3. c1eb748
   4. 1c6672e
   5. 9bd848a
   6. f18ab23
   7. da7bb72
   8. 379027f
   9. be1d79a
   10. 3eb3553
   11. 9985552
magento-engcom-team pushed a commit that referenced this issue Dec 10, 2020
@gabrieldagama
ENGCOM-8501: Fix issue #30270 Product Reviews can not be sorted by Ad…
40f2b85 
…min on the Product edit page #30477
@Chandresh22 Chandresh22 mentioned this issue Aug 11, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Chandresh22 Chandresh22

Labels
CD Issue recommended for the contribution day Component: Other Event: dmcdindia2020 Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Reported on 2.3.5-p2 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
High Priority Backlog
Archived in project
Milestone
No milestone
5 participants
@sivaschenko @magento-engcom-team @Sweetyagarwal @Chandresh22 @github-jira-sync-bot