Fix issue #30270 Product Reviews can not be sorted by Admin on the Product edit page #30477

Chandresh22 · 2020-10-13T03:49:27Z

Description (*)

Product Reviews can not be sorted by Admin on the Product edit page so that resolve this issue.
after changes code Records of "Product Reviews" grid are sorted.

Related Pull Requests

Fixed Issues (if relevant)

Create a few reviews for the product
Create an object of ReviewDataProvider with request param with some sorting order and current_product_id
Assert that sorting order will be applied for review items by calling
Review/Ui/DataProvider/Product/ReviewDataProvider::getData()

Fixes “Product Reviews” can not be sorted by Admin on the Product page #30270 Product Reviews can not be sorted by Admin on the Product Edit page

Manual testing scenarios (*)

"Steps to reproduce" from the “Product Reviews” can not be sorted by Admin on the Product page #30270 Product Reviews can not be sorted by Admin on the Product Edit page

Questions or comments

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds are green)

m2-assistant · 2020-10-13T03:49:30Z

Hi @Chandresh22. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

eduard13 · 2020-10-13T07:01:25Z

@magento run all tests

eduard13

Hi @Chandresh22, thank you for your contribution. However, due to Magento Definition of Done the changes should be covered by tests. Could you please cover your fix by a MFTF test, that will pass through all the steps and then assert that the grid sorting works?

Thank you.

Chandresh22 · 2020-10-13T09:02:32Z

@eduard13 can you help me what is mean Auto Test not covered? and how to resolve this thanks.

eduard13 · 2020-10-13T09:12:34Z

@Chandresh22 as mentioned in my previous comment, in order to deliver this fix, it should be covered by automated tests. I suggest adding a simple MFTF test, that will make sure that the grid sorting works as expected.
Also could you additionally check and fix the failing Static Tests, they aren’t related to your changes, however would be great to have all the checks green ✅

Chandresh22 · 2020-10-13T09:36:49Z

@magento run Static Tests

Chandresh22 · 2020-10-13T11:48:22Z

@magento run all tests

Chandresh22 · 2020-10-13T13:05:23Z

@magento run all tests

eduard13

Please check my comments below. Additionally, as far there is already a Unit Test that covers this class, please update accordingly your test cases.

Thanks.

eduard13 · 2020-10-14T06:30:13Z

app/code/Magento/Review/Ui/DataProvider/Product/ReviewDataProvider.php

+        $params = $this->request->getParams();
+        if (isset($params['sorting'])) {
+            $sorting = $this->request->getParam('sorting');


Please check a more simplified version that should also work.

Suggested change

$params = $this->request->getParams();

if (isset($params['sorting'])) {

$sorting = $this->request->getParam('sorting');

if ($sorting = $this->request->getParam('sorting', null)) {

eduard13 · 2020-10-14T06:31:08Z

app/code/Magento/Review/Ui/DataProvider/Product/ReviewDataProvider.php

@@ -79,7 +87,8 @@ public function getData()
    }

    /**
-     * {@inheritdoc}
+     * @inheritdoc
+     * @return mixed


As far as I can see it doesn't return anything. Am I missing something? This change should fix the Static Tests and Semantic Version Checker.

Suggested change

* @return mixed

* @return void

@eduard13 thanks for suggestion

@eduard13 check the screenshot it shows error http://prntscr.com/uz4ukj
but i don't change in it. this function has as it is.

Chandresh22 · 2020-10-14T11:19:33Z

@magento run all tests

eduard13 · 2020-10-14T13:15:05Z

@magento run Static Tests, Semantic Version Checker

eduard13 · 2020-10-14T18:17:37Z

@Chandresh22 please fix the rest of static fails, and adjust the Unit Test that is currently failing.
Then could you please squash your commits into one and force push it? Looks like something went wrong with the build, it doesn't see the latest updates.

Unfortunately you're not using a branch for these changes, so I cannot help you updating the code 😞 .

Chandresh22 · 2020-10-15T09:11:15Z

okay @eduard13 i will check

Chandresh22 · 2020-10-15T13:50:38Z

@magento run all tests

eduard13 · 2020-10-18T15:49:38Z

@magento run Static Tests, Unit Tests, Semantic Version Checker.

@Chandresh22 any reasons of why have you reverted the changes I suggested? Also have you had any problems with squashing the commits into one commit, in order to have a clean history?
Moreover, there is a failing Unit Test that you have to adjust including your changes.

Let me know if you have any questions on my feedback.
Thanks.

Chandresh22 · 2020-10-19T10:48:37Z

@magento run Static Tests, Unit Tests

magento-engcom-team · 2020-12-01T13:43:43Z

Hi @eduard13, thank you for the review.
ENGCOM-8501 has been created to process this Pull Request

engcom-Alfa · 2020-12-01T14:33:34Z

✔️ QA Passed

Manual testing scenario:

Go to the Storefront as a guest
Go to the created Product page
Add at least 2 reviews
Go to Magento Admin > Marketing > Pending Reviews
Approve the added reviews
Go to Magento Admin > Ctalog > Products
Select the created Product
Click on the “Edit” link
Open the “Product Reviews” section
Sort “Product Reviews” for example, by ID, click the “ID” cell

Before: ✖️ Records of “Product Reviews” grid are not sorted

After: ✔️ All records of “Product Reviews” were sorted by selected parameter

✔️ Also was checked Filters functionality and everything works as expected.

…min on the Product edit page #30477

m2-assistant · 2020-12-10T12:42:07Z

Hi @Chandresh22, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

ghost added the Progress: pending review label Oct 13, 2020

magento-engcom-team added Component: Review Release Line: 2.4 labels Oct 13, 2020

eduard13 self-requested a review October 13, 2020 07:01

eduard13 self-assigned this Oct 13, 2020

eduard13 requested changes Oct 13, 2020

View reviewed changes

ghost added Progress: needs update and removed Progress: pending review labels Oct 13, 2020

Chandresh22 changed the title ~~Update ReviewDataProvider.php~~ Fix issue #30270 Product Reviews can not be sorted by Admin on the Product edit page Oct 13, 2020

Chandresh22 requested a review from eduard13 October 13, 2020 09:09

eduard13 requested changes Oct 14, 2020

View reviewed changes

m2-community-project bot added Progress: testing in progress and removed Progress: ready for testing labels Dec 1, 2020

eduard13 approved these changes Dec 1, 2020

View reviewed changes

m2-community-project bot added Progress: ready for testing and removed Progress: testing in progress labels Dec 1, 2020

m2-community-project bot added Progress: testing in progress and removed Progress: ready for testing labels Dec 1, 2020

engcom-Alfa added the QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope label Dec 3, 2020

m2-community-project bot added Progress: ready for testing and removed Progress: testing in progress labels Dec 3, 2020

m2-community-project bot added Progress: testing in progress and removed Progress: ready for testing labels Dec 3, 2020

m2-community-project bot added Progress: extended testing and removed Progress: testing in progress labels Dec 3, 2020

m2-community-project bot added Progress: accept and removed Progress: extended testing labels Dec 3, 2020

magento-engcom-team mentioned this pull request Dec 10, 2020

“Product Reviews” can not be sorted by Admin on the Product page #30270

Closed

magento-engcom-team pushed a commit that referenced this pull request Dec 10, 2020

ENGCOM-8501: Fix issue #30270 Product Reviews can not be sorted by Ad…

40f2b85

…min on the Product edit page #30477

magento-engcom-team merged commit 0b893ee into magento:2.4-develop Dec 10, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix issue #30270 Product Reviews can not be sorted by Admin on the Product edit page #30477

Fix issue #30270 Product Reviews can not be sorted by Admin on the Product edit page #30477

Chandresh22 commented Oct 13, 2020 •

edited

Loading

m2-assistant bot commented Oct 13, 2020

eduard13 commented Oct 13, 2020

eduard13 left a comment •

edited

Loading

Chandresh22 commented Oct 13, 2020

eduard13 commented Oct 13, 2020

Chandresh22 commented Oct 13, 2020

Chandresh22 commented Oct 13, 2020

Chandresh22 commented Oct 13, 2020

eduard13 left a comment •

edited

Loading

eduard13 Oct 14, 2020

eduard13 Oct 14, 2020

Chandresh22 Oct 14, 2020

Chandresh22 Oct 14, 2020

Chandresh22 commented Oct 14, 2020

eduard13 commented Oct 14, 2020

eduard13 commented Oct 14, 2020 •

edited

Loading

Chandresh22 commented Oct 15, 2020

Chandresh22 commented Oct 15, 2020

eduard13 commented Oct 18, 2020

Chandresh22 commented Oct 19, 2020

magento-engcom-team commented Dec 1, 2020

engcom-Alfa commented Dec 1, 2020

m2-assistant bot commented Dec 10, 2020

Fix issue #30270 Product Reviews can not be sorted by Admin on the Product edit page #30477

Fix issue #30270 Product Reviews can not be sorted by Admin on the Product edit page #30477

Conversation

Chandresh22 commented Oct 13, 2020 • edited Loading

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

m2-assistant bot commented Oct 13, 2020

eduard13 commented Oct 13, 2020

eduard13 left a comment • edited Loading

Choose a reason for hiding this comment

Chandresh22 commented Oct 13, 2020

eduard13 commented Oct 13, 2020

Chandresh22 commented Oct 13, 2020

Chandresh22 commented Oct 13, 2020

Chandresh22 commented Oct 13, 2020

eduard13 left a comment • edited Loading

Choose a reason for hiding this comment

eduard13 Oct 14, 2020

Choose a reason for hiding this comment

eduard13 Oct 14, 2020

Choose a reason for hiding this comment

Chandresh22 Oct 14, 2020

Choose a reason for hiding this comment

Chandresh22 Oct 14, 2020

Choose a reason for hiding this comment

Chandresh22 commented Oct 14, 2020

eduard13 commented Oct 14, 2020

eduard13 commented Oct 14, 2020 • edited Loading

Chandresh22 commented Oct 15, 2020

Chandresh22 commented Oct 15, 2020

eduard13 commented Oct 18, 2020

Chandresh22 commented Oct 19, 2020

magento-engcom-team commented Dec 1, 2020

engcom-Alfa commented Dec 1, 2020

m2-assistant bot commented Dec 10, 2020

Chandresh22 commented Oct 13, 2020 •

edited

Loading

eduard13 left a comment •

edited

Loading

eduard13 left a comment •

edited

Loading

eduard13 commented Oct 14, 2020 •

edited

Loading