-
Notifications
You must be signed in to change notification settings - Fork 9.4k
[Issue] Initialize authentication popup modal only when needed #30672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hi @engcom-Delta. Thank you for working on this issue.
|
✅ Confirmed by @engcom-Delta Issue Available: @engcom-Delta, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself. |
This issue is automatically created based on existing pull request: #30647: Initialize authentication popup modal only when needed
Description (*)
This PR is somehow an evolution of the #27686 in which I have found that it is not possible to completely skip initialization of authentication popup. That said, by adding this additional check, we are able to save a lot of CPU time for all of the shops that have guest checkout enabled.
Here are the profiles of before:


and after:
Manual testing scenarios (*)
setModalElement
function is no longer called when guest checkout is enabled.Contribution checklist (*)
The text was updated successfully, but these errors were encountered: